Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #18820: updated docker compose files #18821

Merged
merged 14 commits into from
Jan 9, 2025
Merged

fixes #18820: updated docker compose files #18821

merged 14 commits into from
Jan 9, 2025

Conversation

tarunpandey23
Copy link
Contributor

@tarunpandey23 tarunpandey23 commented Nov 27, 2024 •
edited
Loading

Describe your changes:

Optimized docker files, and created a common environment so that it can be reused anywhere in the compose file.

Fixes #18820

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@tarunpandey23 tarunpandey23 mentioned this pull request Nov 27, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@tarunpandey23 tarunpandey23 changed the title Updated docker compose files Update: Updated docker compose files Nov 27, 2024
@tarunpandey23 tarunpandey23 changed the title Update: Updated docker compose files fixes #18820: updated docker compose files Nov 27, 2024
@tarunpandey23 tarunpandey23 reopened this Nov 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@akash-jain-10 akash-jain-10 added the safe to test Add this label to run secure Github workflows on PRs label Nov 28, 2024
@akash-jain-10 akash-jain-10 force-pushed the feat/updated-docker-files branch from 45968f2 to 3ebbde0 Compare December 11, 2024 06:28
Prajwal214
Prajwal214 previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@Prajwal214 Prajwal214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ayush-shah ayush-shah merged commit 69dd8b9 into open-metadata:main Jan 9, 2025
11 checks passed
chirag-madlani added a commit that referenced this pull request Jan 9, 2025
@chirag-madlani
Revert "fixes #18820: updated docker compose files (#18821)"
b49ae37 
This reverts commit 69dd8b9.
@chirag-madlani chirag-madlani mentioned this pull request Jan 9, 2025
Merged
akash-jain-10 pushed a commit that referenced this pull request Jan 9, 2025
@chirag-madlani
Revert "fixes #18820: updated docker compose files (#18821)" (#19297)
a43835d 
This reverts commit 69dd8b9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-jain-10 akash-jain-10 akash-jain-10 left review comments

@Prajwal214 Prajwal214 Prajwal214 left review comments

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@tutte tutte Awaiting requested review from tutte tutte is a code owner

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize Docker compose files.
4 participants
@tarunpandey23 @akash-jain-10 @Prajwal214 @ayush-shah