Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Create Team to use entityName for create requests #19087

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Update Create Team to use entityName for create requests #19087

wants to merge 14 commits into from

Conversation

mohityadav766
Copy link
Contributor

@mohityadav766 mohityadav766 commented Dec 16, 2024 •
edited by Ashish8689
Loading

Describe your changes:

Fixes

Backed :

  • Change the field data of parent, default role, policies and user from ID to FQN for creating the Team.

UI :

  • Change the field data of parent from ID to FQN for creating the Team.
  • For the deleted team, fix the join team button appearing there.
  • For the deleted team, fix the add user button that is still clickable, even the button is disabled!

Issue :

Screen.Recording.2024-12-16.at.5.49.50.PM.mov

Fixed :

Screen.Recording.2024-12-16.at.5.49.11.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 self-assigned this Dec 16, 2024
@mohityadav766
Copy link
Contributor Author

@Ashish8689 can you please check the UI side for this, we are still using ids on the request, i think we should change it to fqns like we did for other entities, need it for some other WIP

@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.63% (40845/63200) 40.9% (16414/40136) 44.06% (4963/11264)

sonika-shah
sonika-shah reviewed Jan 16, 2025
View reviewed changes
...-service/src/main/java/org/openmetadata/service/apps/bundles/searchIndex/SearchIndexApp.java
new BufferedWriter(
new FileWriter(
String.format(
"/Users/mohityadav/IdeaProjects/OMTesting/sample_data/%s.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might need to a give a relative path here cc @mohityadav766

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed , will remove this

@sonika-shah sonika-shah requested a review from a team January 16, 2025 10:17
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonika-shah sonika-shah sonika-shah left review comments

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

At least 1 approving review is required to merge this pull request.

Assignees

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohityadav766 @sonika-shah @ayush-shah @Ashish8689