Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the search for custom properties in advance search for some types #19113

Merged
merged 12 commits into from
Jan 8, 2025

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Dec 17, 2024

Describe your changes:

Fixes for the Issue #19069

Backed :

  • Supported Config in the Custom Property Type API

UI Improvement :

  • Fix the Custom Property search for the Following Types:

    • Duration (Equal, Contains Operators)
    • Text and String (Equal, Contains Operators, also around the Capital casing not found)
    • Integer, Number and TimeStamp (Added range property here to find the properties within the integer range)
    • Markdown and SQL Query (For the Capital Case)
    • Enum (Singular) (supported enum selectors based on that type for easy access)
    • Email (Contains Operators)
    • Date (Supported date search for yyyy-MM-dd format, with the range selector to find the properties within the date range)
    • EntityReference and List - (Supported respective type to be visible in the dropdown.)
      NOTE: Entity having space in the name, will not get a result. This will be fixed in the next release.
  • Type needs to work:

    • TimeInterval
    • Table
    • EntityReference and List
    • Enum multiple
    • Email (Equal Operator not working)
  • Not Supported Custom Property for Elastic Search :

    • Date Formats:
      • dd MMM yyyy, MM/dd/yyyy, dd/MM/yyyy, dd-MM-yyyy, yyyyDDD, d MMMM yyyy formats are not supported by Elastic search and only yyyy-MM-dd is supported.
    • Date Time : Not supported by Elastic Search
    • Time : Not Supported By Elastic Search
    image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@Ashish8689 Ashish8689 marked this pull request as ready for review January 7, 2025 16:10
@Ashish8689 Ashish8689 requested review from a team as code owners January 7, 2025 16:10
@Ashish8689 Ashish8689 changed the title WIP: fix the search in advance search custom properties fix the search for custom properties in advance search for some types Jan 7, 2025
@Ashish8689 Ashish8689 added the To release Will cherry-pick this PR into the release branch label Jan 7, 2025
Copy link

sonarqubecloud bot commented Jan 8, 2025

Copy link

sonarqubecloud bot commented Jan 8, 2025

@chirag-madlani chirag-madlani merged commit 2179b43 into main Jan 8, 2025
23 of 27 checks passed
@chirag-madlani chirag-madlani deleted the custom-property-advance-search branch January 8, 2025 05:38
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Failed to cherry-pick changes to the 1.6.2 branch.
Please cherry-pick the changes manually.
You can find more details here.

Ashish8689 added a commit that referenced this pull request Jan 8, 2025
…#19113)

* fix the search in advance search custom properties

* modify v1/metadata/types/customProperties api to get customPropertyConfig along with name and type

* added config list in the entity ref list

* fix type of duration, timestamp and other types

* minor ui changes

* remove customProperty type which are not supported for now

* added playwright test around the duration type property

* fix flaky test

---------

Co-authored-by: sonikashah <[email protected]>
(cherry picked from commit 2179b43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants