Feature: Docker Host Retry #19127
Merged
Feature: Docker Host Retry #19127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
ulixius9
added
the
safe to test
…_docker_host decorator
…into feature/dockerhost-retry
…re creating source class
…into feature/dockerhost-retry
…into feature/dockerhost-retry
ulixius9
reviewed
Jan 6, 2025
Comment on lines
+78
to
+83
| if "localhost" in host_port_str: | ||
| result = test_connection_fn(metadata, connection, request.connection.config) | ||
| raise_test_connection_exception(result) | ||
|
|
||
| test_connection_fn( | ||
| metadata, connection, request.connection.config, automation_workflow |
There was a problem hiding this comment.
does this mean we run the test connection twice in case of localhost and when no exception is thrown?
There was a problem hiding this comment.
Yes, we need to do this to show the result of test_connection on the frontend
…into feature/dockerhost-retry
ulixius9
approved these changes
Jan 13, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
I implemented a retry mechanism for the service connection, replacing localhost with host.docker.internal if a connection error occurs.
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>