Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(ui): refresh call concurrency for multiple browser tabs #19303

Merged
merged 19 commits into from
Jan 20, 2025
Merged

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Jan 9, 2025

Describe your changes:

Fixes #19310

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.64% (40856/63203) 40.89% (16417/40147) 44.09% (4967/11265)

Copy link

Copy link

@chirag-madlani chirag-madlani merged commit 00a37c6 into main Jan 20, 2025
23 of 27 checks passed
@chirag-madlani chirag-madlani deleted the fix-auth branch January 20, 2025 18:01
Copy link
Contributor

Failed to cherry-pick changes to the 1.6.3 branch.
Please cherry-pick the changes manually.
You can find more details here.

chirag-madlani added a commit that referenced this pull request Jan 24, 2025
* fix(ui): refresh auth token for multi browser tabs

* update refresh logic

* fix multiple tab issue

* fix tests

* added tests

* fix ingestion bot failure

* fix sonar cloud

* update test description

* remove unused code and reset test on after all

* bump playwright

* avoid running refresh tests as it's been flaky for postgres

* revert playwright version bump changes

* Put 500 status

---------

Co-authored-by: mohitdeuex <[email protected]>
(cherry picked from commit 00a37c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: renewal token running into issue when using with multiple tabs
4 participants