Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds percona server for postgresql support #19322

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agriev
Copy link

@agriev agriev commented Jan 10, 2025

Describe your changes:

Fixes issue with inability to collect metadata from percona for postgresql server

discussed here: slack thread

The only meaningful difference between vanilla postgreSQL and Percona is version string in percona server for postgresql. So commit propose universal and safe way to detect server version by integer string and not complicated parsing of unformatted string.

tested on both postgresql and percona instances, fix is not affecting anything except version check logic in this particular scenario, works the same for vanilla postgreSQL

I worked on it because we need it in out infrastructure and we are using it everyday

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Improvement - no changes in tests and docs necessary

  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

The only meaningful difference is version string in percona server for postgresql. So commit propose universal and safe way to detect server version by integer string, not complicated parsing of unformatted string.
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants