Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing nil pointer error when converting VAPB from v1beta1 to v1, CP (#3754) #3765

Merged

Conversation

JaydipGabani
Copy link
Contributor

Signed-off-by: Jaydip Gabani [email protected]
(cherry picked from commit 14e6c8a)

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@JaydipGabani JaydipGabani requested a review from a team as a code owner January 8, 2025 22:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-3.18@bb0103c). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-3.18    #3765   +/-   ##
===============================================
  Coverage                ?   47.70%           
===============================================
  Files                   ?      236           
  Lines                   ?    19924           
  Branches                ?        0           
===============================================
  Hits                    ?     9504           
  Misses                  ?     9526           
  Partials                ?      894           
Flag Coverage Δ
unittests 47.70% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaydipGabani JaydipGabani merged commit bc36bee into open-policy-agent:release-3.18 Jan 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants