fix: Add Missing Flags as Helm Values #3787
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
ianstanton
commented
Jan 17, 2025
Comment on lines
+18
to
+22
| volumeMounts: | ||
| - mountPath: /certs | ||
| name: cert | ||
| readOnly: true | ||
| $patch: delete |
There was a problem hiding this comment.
I added these here to avoid duplicate entries when generating manifests. I renamed the file as it is no longer only deleting ports.
| @@ -8,7 +8,7 @@ bases: | |||
| - "../../../config/default" | |||
| patchesStrategicMerge: | |||
| - kustomize-for-helm.yaml | |||
| - delete-ports.yaml | |||
| - delete-merge-values.yaml | |||
There was a problem hiding this comment.
Renamed file mentioned above.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3787 +/- ##
==========================================
- Coverage 54.49% 47.69% -6.80%
==========================================
Files 134 236 +102
Lines 12329 19929 +7600
==========================================
+ Hits 6719 9506 +2787
- Misses 5116 9529 +4413
- Partials 494 894 +400
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add the following flags as helm values and pass down to
controller-managerandauditdeployment templates:--log-level-key--log-level-encoder--cert-dir--api-cache-dir--otlp-endpoint--otlp-metric-interval--stackdriver-only-when-available--stackdriver-metric-interval--disable-enforcementaction-validation--client-ca-name--client-cn-nameWhich issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #3784
Special notes for your reviewer:
I left some of the missing flags in #3784 out as I'm still determining whether they belong as chart values. I also want to be sure the right flags are passed to the appropriate deployments (some are applied to both, others are unique to
controller-manageroraudit), so feedback is welcome there.