Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OTEL_SDK_DISABLED #3245

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Jan 15, 2025

Fixes #1631

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 624fdc7
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/678c2bf6ce9e4d0008961bf3

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (25f7a13) to head (624fdc7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3245      +/-   ##
==========================================
+ Coverage   87.78%   87.83%   +0.06%     
==========================================
  Files         198      202       +4     
  Lines        6308     6334      +26     
==========================================
+ Hits         5537     5563      +26     
  Misses        771      771              
Files with missing lines Coverage Δ
api/include/opentelemetry/logs/provider.h 100.00% <100.00%> (ø)
api/include/opentelemetry/metrics/provider.h 100.00% <ø> (ø)
api/include/opentelemetry/trace/provider.h 100.00% <ø> (ø)
exporters/ostream/test/ostream_log_test.cc 96.18% <100.00%> (ø)
sdk/src/common/disabled.cc 100.00% <100.00%> (ø)
sdk/src/logs/provider.cc 100.00% <100.00%> (ø)
sdk/src/metrics/provider.cc 100.00% <100.00%> (ø)
sdk/src/trace/provider.cc 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK] Support OTEL_SDK_DISABLED environment variable
1 participant