-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SdkTracerProvider.setScopeConfigurator() and support #7021
base: main
Are you sure you want to change the base?
add SdkTracerProvider.setScopeConfigurator() and support #7021
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7021 +/- ##
============================================
- Coverage 89.95% 89.89% -0.06%
- Complexity 6636 6660 +24
============================================
Files 745 748 +3
Lines 20010 20095 +85
Branches 1962 1969 +7
============================================
+ Hits 17999 18064 +65
- Misses 1415 1437 +22
+ Partials 596 594 -2 ☔ View full report in Codecov by Sentry. |
@open-telemetry/java-approvers any idea why the graal build is failing? |
looks like it was a sporadic issue, @laurit re-ran and it's passing now |
@@ -100,6 +102,17 @@ public Sampler getSampler() { | |||
return sharedState.getSampler(); | |||
} | |||
|
|||
// currently not public as experimental |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pattern for giving access to these experimental features has been via Sdk{Signal}ProviderUtil
, a public class in an internal package, with static helper methods for reflectively accessing package private methods.
For tracing, this is SdkTracerProviderUtil
.
I'd recommend adding an accessor method there as part of this PR. If you do, please add javadoc to this pointing to that method.
If you choose to punt on that, let's add a TODO to followup:
// currently not public as experimental | |
// TODO: add public experimental accessor in SdkTracerProviderUtil |
Speaking of followups, after landing this, should open an issue to track extending metrics and logs with the same capability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the static helper, and opened #7038 for extending to metrics and logs
per discussion here from PR