Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding few functions for right and left legs collision #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adding few functions for right and left legs collision #14

wants to merge 1 commit into from

Conversation

hrahmanin
Copy link
Collaborator

No description provided.

@hrahmanin hrahmanin requested a review from gfudenberg January 16, 2025 03:43
@golobor
Copy link
Member

golobor commented Jan 16, 2025

could you please exclude .ipynb_checkpoints from the commit?
(typically, this is prevented via .gitignore)

@golobor
Copy link
Member

golobor commented Jan 16, 2025

another minor suggestion - i think there may be a much more efficient implementation of the search via np.searchsorted(l_sites, r_sites)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfudenberg gfudenberg Awaiting requested review from gfudenberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hrahmanin @golobor