Refactoring for variable-based encoding: Use same backend object for Iterations container and the Iterations themselves #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -185,25 +185,27 @@ | |||
| } | |||
| } | |||
|
|
|||
| TEST_CASE("myPath", "[core]") | |||
| void myPath(std::string const &filename, IterationEncoding ie) | |||
Check warning
Code scanning / CodeQL
Poorly documented large function Warning test
| @@ -313,6 +315,13 @@ | |||
| #endif | |||
| } | |||
|
|
|||
| TEST_CASE("myPath", "[core]") | |||
Check notice
Code scanning / CodeQL
Unused static function Note test
franzpoeschel
force-pushed
the
variablebasedencoding-writables
branch
from
ac1564c to
400e1e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this should be merged, there are pros and cons. But while exploring this, there were some subtle cleanups and fixes that should at least be extracted.
myPath(). Maybe pointfrontend_parenttoseries.iterationsand not the Series itself?