Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Module name from opmd_viewer to openpmd_viewer #240

Merged
merged 2 commits into from
Jul 28, 2019

Conversation

RemiLehe
Copy link
Member

@RemiLehe RemiLehe commented Jul 27, 2019

As discussed with @ax3l and @soerenjalas, in version 1.0, we will replace

import opmd_viewer

by

import openpmd_viewer

This is what the current PR does, by:

  • git mv-ing the whole opmd_viewer folder to openpmd_viewer
  • sed-ing all relevant files to automatically change opmd_viewer into openpmd_viewer

There will also be a later PR that leaves a stub, so that importing opmd_viewer will raise an Exception (prompting the user to either downgrade to version 0.X or to change the import syntax.)

@RemiLehe RemiLehe requested a review from ax3l July 27, 2019 21:28
@ax3l ax3l changed the title Replace package name from opmd_viewer to openpmd_viewer Replace Module name from opmd_viewer to openpmd_viewer Jul 28, 2019
@ax3l
Copy link
Member

ax3l commented Jul 28, 2019

Thx! Just a small typo left.

I renamed the PR title accordingly, since the "python import"-name is the "module" name. The package name (#223) would be the PyPI (already correct), spack (todo) or conda(-forge) name (todo when I am back).

Ref.s:

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Axel Huebl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants