Skip to content

Commit

Permalink
Fix the KVM terminal screen not displaying
Browse files Browse the repository at this point in the history
During the upgrade to Vue 3 [1], the initialization of the selector,
including the definitions of height, display type, background, overflow,
etc., was ignored, resulting in the KVM screen not displaying the
terminal interface. This commit helps to import these properties for the
KVM from the _kvm.scss file to fix bug [2].

Tested:
 1. Go to the OBMC web page.
 2. Go to the KVM page and check that it works normally
 3. By minifying and zooming in on the web browser, the KVM screen
    adjusts automatically.
 4. Switch between different pages.
 5. Return to the KVM page and check that it works normally.

[1]. https://github.com/openbmc/webui-vue/blob/master/src/App.vue#L38
[2]. Bug: #128

Change-Id: I1842c914e27dd5c68fe20f49999712b68c1e93a5
Signed-off-by: Huy Le Anh <[email protected]>
  • Loading branch information
HuyLeAnh committed Nov 18, 2024
1 parent ce7db82 commit b449867
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/views/Operations/Kvm/KvmConsole.vue
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,10 @@ export default {
};
</script>

<style lang="scss">
@import '@/assets/styles/bmc/custom/_kvm.scss';
</style>

<style lang="scss" scoped>
@import '@/assets/styles/bmc/helpers/_index.scss';
@import '@/assets/styles/bootstrap/_helpers.scss';
Expand Down

0 comments on commit b449867

Please sign in to comment.