Merge pull request #634 from stefopl/okapi-633

fix(#633): handle invalid UUIDs in found_by parameter
opencaching · Dec 10, 2024 · 3aab571 · 3aab571
2 parents 4e4db56 + 8f8c880
commit 3aab571
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/okapi/services/caches/search/SearchAssistant.php b/okapi/services/caches/search/SearchAssistant.php
@@ -427,6 +427,23 @@ public function prepare_common_search_params()
                 throw new InvalidParam('found_by', $e->whats_wrong_about_it);
             }
 
+            if (empty($users) || !is_array($users)) {
+                throw new InvalidParam('found_by', "No valid users found for the given parameter.");
+            }
+
+            $user_uuids = explode("|", $tmp);
+
+            $invalid_uuids = [];
+            foreach ($user_uuids as $uuid) {
+                if (!isset($users[$uuid])) {
+                    $invalid_uuids[] = $uuid;
+                }
+            }
+
+            if (!empty($invalid_uuids)) {
+                throw new InvalidParam('found_by', "The following UUID(s) are invalid or not found: " . implode(", ", $invalid_uuids));
+            }
+
             $internal_user_ids = array_map(function ($user) { return $user["internal_id"]; }, $users);
             if (Settings::get('USE_SQL_SUBQUERIES')) {
                 $found_cache_subquery = self::get_found_cache_ids_subquery($internal_user_ids);