Add support for creating/modifying IPMC group with member list. #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kishore Gummadidala <[email protected]>
| * | ||
| * @type sai_object_list_t | ||
| * @flags CREATE_AND_SET | ||
| * @objects SAI_OBJECT_TYPE_NEXT_HOP |
There was a problem hiding this comment.
why only nexthop, IPMC member create support RIF, Tunnel also
There was a problem hiding this comment.
IIUC the object list check requires the list to contain a single object type..
| * @brief IPMC output list | ||
| * | ||
| * @type sai_object_list_t | ||
| * @flags CREATE_AND_SET |
There was a problem hiding this comment.
As per your design, NOS should send all members during SET so that SAI can replace all existing members, that is not captured here
kcudnik
approved these changes
Dec 15, 2024
|
@JaiOCP - could you please help review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for creating/modifying IPMC group with member list.