Skip to content

Commit

Permalink
deploy - correct go install output
Browse files Browse the repository at this point in the history
Upon an invalid `kind` version, the following message is displayed:
Error: failed to deploy cluster: failed to check for dependencies: kind version check failed: got 0.19.0, want 0.24.0. install with `go install sigs.k8s.io/[email protected]`

Executing the instruction fails, due to an in-valid version tag:
`go: sigs.k8s.io/[email protected]: sigs.k8s.io/[email protected]: invalid version: unknown revision 0.24.0`

The `v` is being stripped off by `parseVersion` as changed in 1d152a.

Since `parseVersion` explicitly requires a `v` prefix, it should be safe
to just add this back in the human output.
  • Loading branch information
DamianZaremba committed Jan 5, 2025
1 parent 7c6ae73 commit c306492
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deploy/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ func (k *KindSpec) checkDependencies() error {
return fmt.Errorf("kind version check failed: %w", err)
}
if gotV.LT(wantV) {
return fmt.Errorf("kind version check failed: got %s, want %s. install with `go install sigs.k8s.io/kind@%s`", gotV, wantV, wantV)
return fmt.Errorf("kind version check failed: got %s, want %s. install with `go install sigs.k8s.io/kind@v%s`", gotV, wantV, wantV)
}
log.Infof("kind version valid: got %s want %s", gotV, wantV)
}
Expand Down

0 comments on commit c306492

Please sign in to comment.