Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apply kubeyaml rpc to KNE grpc server #464

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Add apply kubeyaml rpc to KNE grpc server #464

merged 6 commits into from
Dec 1, 2023

Conversation

alexmasi
Copy link
Contributor

@alexmasi alexmasi commented Nov 29, 2023

Now kubeyaml can be applied to a cluster through the controller server

@alexmasi alexmasi requested a review from bormanp November 29, 2023 00:58
Copy link

github-actions bot commented Nov 29, 2023

Pull Request Test Coverage Report for Build 7053230440

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 33 of 50 (66.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 65.621%

Changes Missing Coverage Covered Lines Changed/Added Lines %
exec/exec.go 0 1 0.0%
exec/fake/fake.go 0 1 0.0%
deploy/deploy.go 33 39 84.62%
controller/server/main.go 0 9 0.0%
Totals Coverage Status
Change from base Build 7023015514: -0.05%
Covered Lines: 4079
Relevant Lines: 6216

💛 - Coveralls

deploy/deploy.go Show resolved Hide resolved
deploy/deploy.go Outdated Show resolved Hide resolved
cmd/deploy/deploy.go Outdated Show resolved Hide resolved
deploy/deploy.go Outdated Show resolved Hide resolved
deploy/deploy.go Show resolved Hide resolved
@alexmasi
Copy link
Contributor Author

Adding the unit tests in a follow up commit to this PR

I intended to include them originally, wanted to make sure we were on the same page with the functionality and impl before writing them (I should have mentioned that in the description, sorry)

@alexmasi alexmasi changed the title Add apply cmd to KNE Add apply kubeyaml rpc to KNE grpc server Nov 30, 2023
)

func runCommand(writeLogs bool, in []byte, cmd string, args ...string) ([]byte, error) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice reduction in duplicated code!

@bormanp bormanp merged commit 7ecf53e into main Dec 1, 2023
7 checks passed
@alexmasi alexmasi deleted the apply branch December 1, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants