-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apply kubeyaml rpc to KNE grpc server #464
Conversation
Pull Request Test Coverage Report for Build 7053230440Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Adding the unit tests in a follow up commit to this PR I intended to include them originally, wanted to make sure we were on the same page with the functionality and impl before writing them (I should have mentioned that in the description, sorry) |
) | ||
|
||
func runCommand(writeLogs bool, in []byte, cmd string, args ...string) ([]byte, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice reduction in duplicated code!
Now kubeyaml can be applied to a cluster through the controller server