Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v2.8.0 #735

Merged
merged 19 commits into from
Oct 28, 2024
Merged

Merge v2.8.0 #735

merged 19 commits into from
Oct 28, 2024

Conversation

HumairAK
Copy link
Contributor

Merge v2.8.0

HumairAK and others added 19 commits October 17, 2024 16:16
Setting the same image that rhoai dashboard is currently using

Signed-off-by: Jorge Garcia Oncins <[email protected]>
…y-image

fix: update oauth-proxy-image and MLMD Envoy images
when a dspa is marked for deletion, there is no state logic to handle
dspa statuses, so the update can at times try to update a dspa that may
have already been deleted, this change should prevent (or reduce) the
chances of this happening, in the future proper/graceful dspa
termination handling should be added

Signed-off-by: Humair Khan <[email protected]>
…_err

prevent dspa status update on a terminating dspa
This change adds a new apiversion "v1", which will remove all the dsp "v1" related fields, and also defaults to dsp "v2". The new apiversion is set as the stored version, however k8s will continue to serve v1alpha1, however it is deprecated.

All tests are updated acordingly.

Signed-off-by: Humair Khan <[email protected]>
This change makes it so that new reconciles on dspa owned resources are
labelled with a dsp-version=<dspa-version> label. This is to allow for
the dspa selectively watch (for manual WatchesRawSources) on resources
that are descendents of DSPAs with .spec.dspVersion set to supported
versions.

Signed-off-by: Humair Khan <[email protected]>
Chore: Remove v1 fields and reconcile logic from dspo
this will match the config path to what we are specifying for env vars
for the pa image foudn in config/base/params.env i.e.
IMAGES_PERSISTENCEAGENT should match Images.PersistenceAgent

Signed-off-by: Humair Khan <[email protected]>
@openshift-ci openshift-ci bot requested review from DharmitD and rimolive October 28, 2024 13:55
Copy link
Contributor

openshift-ci bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-735
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/735/head
git checkout -b pullrequest 57db0b4d0839776a1c1382ba207f0a987e4dd23d
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-735"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@HumairAK HumairAK merged commit f3b7c70 into opendatahub-io:stable Oct 28, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants