Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added retry for integration test #737

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Nov 4, 2024

Description of your changes:

This PR adds a retry for an integration test that fails for not having all pods running.

Testing instructions

CI must pass.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@hbelmiro hbelmiro force-pushed the fix-its branch 2 times, most recently from 20c28ce to 4204d49 Compare November 4, 2024 17:33
@hbelmiro hbelmiro changed the title Fixed flakiness on Integration Tests Added retry for integration test Nov 4, 2024
@hbelmiro hbelmiro marked this pull request as ready for review November 4, 2024 18:17
@openshift-ci openshift-ci bot requested review from gmfrasca and HumairAK November 4, 2024 18:17
@hbelmiro hbelmiro marked this pull request as draft November 4, 2024 18:18
Signed-off-by: Helber Belmiro <[email protected]>
@hbelmiro hbelmiro marked this pull request as ready for review November 4, 2024 18:39
@openshift-ci openshift-ci bot requested a review from DharmitD November 4, 2024 18:39
@HumairAK
Copy link
Contributor

HumairAK commented Nov 4, 2024

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 4, 2024
@HumairAK HumairAK merged commit 0e775db into opendatahub-io:main Nov 4, 2024
4 of 6 checks passed
@hbelmiro hbelmiro deleted the fix-its branch November 4, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants