Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DSPA custom ca cert on MLMD and Persistence Agent clients #739

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Nov 5, 2024

Signed-off-by: Helber Belmiro [email protected]
(cherry picked from commit 40ca5ed)

Signed-off-by: Helber Belmiro <[email protected]>
(cherry picked from commit 40ca5ed)
Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rimolive for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro
Copy link
Contributor Author

hbelmiro commented Nov 5, 2024

/test all

Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

@hbelmiro: No presubmit jobs available for opendatahub-io/data-science-pipelines-operator@stable

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-739
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/739/head
git checkout -b pullrequest 9d06a9f8341cc9c80b2328c6d001bc53a870aa75
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-739"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@hbelmiro hbelmiro marked this pull request as ready for review November 5, 2024 12:09
@openshift-ci openshift-ci bot requested review from DharmitD and rimolive November 5, 2024 12:09
@HumairAK HumairAK merged commit 5ce9a08 into opendatahub-io:stable Nov 5, 2024
5 of 6 checks passed
@hbelmiro hbelmiro deleted the RHOAIENG-13871-stable branch November 5, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants