[Cherry pick] Fix InferenceService state when Predictor pod in CrashLoopBackOff (… #465
+313
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erve#4003) * Requeue and then double check the Pending status Signed-off-by: Hannah DeFazio <[email protected]> * Add test case, fix old tests Signed-off-by: Hannah DeFazio <[email protected]> * Check the retun value for PropagateModelStatus, add knative failure case Signed-off-by: Hannah DeFazio <[email protected]> --------- Signed-off-by: Hannah DeFazio <[email protected]> Co-authored-by: Hannah DeFazio <[email protected]>
openshift-ci
bot
requested review from
israel-hdez and
VedantMahabaleshwarkar
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hdefazio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hdefazio
requested review from
rnetser and
mholder6
and removed request for
VedantMahabaleshwarkar and
israel-hdez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…kserve#4003)
Requeue and then double check the Pending status
Add test case, fix old tests
Check the retun value for PropagateModelStatus, add knative failure case
What this PR does / why we need it:
Cherry pick of kserve#4003
Re-running failed tests
/rerun-all- rerun all failed workflows./rerun-workflow <workflow name>- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.