Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Upstream/master with ODH/master #471

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

spolti
Copy link
Member

@spolti spolti commented Jan 22, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

greenmoon55 and others added 29 commits December 23, 2024 14:35
* squash commits

Signed-off-by: Jin Dong <[email protected]>

* localmodel agent -> localmodelnode agent

Signed-off-by: Jin Dong <[email protected]>

* Revert change

Signed-off-by: Jin Dong <[email protected]>

---------

Signed-off-by: Jin Dong <[email protected]>
* Fix model server fails to gracefully shutdown

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Update unit tests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
kserve#4152)

Ensure root model directory exists and add protection for # of jobs created

Signed-off-by: Dan Sun <[email protected]>
* updated package versions

Signed-off-by: ayush <[email protected]>

* updated go.mod and pip

Signed-off-by: ayush <[email protected]>

* updated poetry lock

Signed-off-by: ayush <[email protected]>

* refactored handling of task argument

Signed-off-by: ayush <[email protected]>

* removed go.mod changes

Signed-off-by: ayush <[email protected]>

---------

Signed-off-by: ayush <[email protected]>
* Add workflow for verifying go mod

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Merge with go lint workflow

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
upgrade aiohttp

Signed-off-by: Andrews Arokiam <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
* Allow other engine builds other than docker

chore:	This change will allow user to use other engine builds.
	In addition, for Podman/Buildah engine builder, users can
	set the target architecture, useful when using ARM and
	there is a need to build x86 Container images.
	Can be done with `ENGINE=podman ARCH="--arch x86_64" make docker...`

Signed-off-by: Spolti <[email protected]>

* review changes

Signed-off-by: Spolti <[email protected]>

---------

Signed-off-by: Spolti <[email protected]>
* Fixes Non-linear parsing of case-insensitive content

chore:	Fixes CVE-2024-45338 Non-linear parsing of case-insensitive content in golang.org/x/net/html
	https://github.com/kserve/kserve/security/dependabot/1871

Signed-off-by: Spolti <[email protected]>

* update go.sum

Signed-off-by: Spolti <[email protected]>

---------

Signed-off-by: Spolti <[email protected]>
* Helm chart - option to run daemonset as root

Signed-off-by: Jin Dong <[email protected]>

* make generate

Signed-off-by: Jin Dong <[email protected]>

* Revert default values

Signed-off-by: Jin Dong <[email protected]>

* Fix job count test

Signed-off-by: Dan Sun <[email protected]>

---------

Signed-off-by: Jin Dong <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
Replace nodeGroup with nodeGroups

Signed-off-by: Rituraj Singh <[email protected]>
Co-authored-by: Rituraj Singh <[email protected]>
* Add affinity and tolerations to localmodel daemonset

Signed-off-by: Jin Dong <[email protected]>

* make generate

Signed-off-by: Jin Dong <[email protected]>

---------

Signed-off-by: Jin Dong <[email protected]>
…#4157)

* sets virtual addressing style for legacy s3 endpoint

Signed-off-by: bentohset <[email protected]>

* add unit test

Signed-off-by: bentohset <[email protected]>

* fix formatting

Signed-off-by: bentohset <[email protected]>

* fix unit tests

Signed-off-by: bentohset <[email protected]>

---------

Signed-off-by: bentohset <[email protected]>
Co-authored-by: Lize Cai <[email protected]>
* Make label and annotation propagation configurable

chore:	Make the DisallaowedAnnotations and Labels configurable through
	ConfigMap so users can configured it quickly.

fixes kserve#3710

Signed-off-by: Spolti <[email protected]>

* generate boilerplate code

Signed-off-by: Spolti <[email protected]>

* Edgar's review changes

Signed-off-by: Spolti <[email protected]>

---------

Signed-off-by: Spolti <[email protected]>
* Add client sdk for localmodelcache, localmodelnodegroup

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add e2e test for modelcache

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Use docker driver and minikube tunnel

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Merge "Allow multiple node groups in the model cache CR (kserve#4134)"

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Try mounting image dir

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add local model agent to image scan

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Debug

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Create model root directory beforehand

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Restart kserve controller after patch

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Enablepvc direct mount in e2e test

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Reduce pv storage to 1GB

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Update modelcache test

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Update status-check to include modelcache logs

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Rajat Vig <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
* [bugfix] fix s3 storage download filename bug

- ensure correct path and file name preservation during s3 downloads in
  storage-initializer

Signed-off-by: Jaeyeon Kim <[email protected]>

* update lint

- fix format

Signed-off-by: Jaeyeon Kim <[email protected]>

* fix format

Signed-off-by: Jaeyeon Kim <[email protected]>

---------

Signed-off-by: Jaeyeon Kim <[email protected]>
* Add boilerplate setup for embeddings api

Signed-off-by: Fabian Scheidt <[email protected]>

* Integrate call to model with embedding request

Signed-off-by: Fabian Scheidt <[email protected]>

* Adjust error responses to be consistent with openai

Signed-off-by: Fabian Scheidt <[email protected]>

* Adjust doc strings to match implementation

Signed-off-by: Fabian Scheidt <[email protected]>

* Update openai input validation to use pydantic

Signed-off-by: Fabian Scheidt <[email protected]>

* Refactor embedding object type

Signed-off-by: Fabian Scheidt <[email protected]>

* Add e2e test for OpenAI embedding endpoint

Signed-off-by: Fabian Scheidt <[email protected]>

* Add unit test for OpenAI embeddings

Signed-off-by: Fabian Scheidt <[email protected]>

---------

Signed-off-by: Fabian Scheidt <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
@spolti spolti requested a review from Jooho January 22, 2025 19:50
Copy link

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jan 22, 2025

@spolti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-fast 7560598 link true /test e2e-fast
ci/prow/e2e-slow 7560598 link true /test e2e-slow
ci/prow/e2e-raw 7560598 link true /test e2e-raw

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: New/Backlog
Development

Successfully merging this pull request may close these issues.