CARRY: enabled lq metrics feature flag #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kload.ResetChecksOnEviction() which (kubernetes-sigs#3470) `ResetChecksOnEviction sets all AdmissionChecks to Pending`. Tested in "workload with retry checks should be evicted and checks should be pending”, thus "the local workload's admission check is set to Pending when it is in Retry without quota" test is no longer realizable.
…tes-sigs#3479) Check that both worker clusters had finished
…tes-sigs#3477) * Reduce number of API requests in the Provisioning Controller * Review remarks.
…s#3454) * Document batch/Job managedBy field usage * Update after code review * Update after code review 2 * Update the MultiKueue concept page * Update after code review * Update site/content/en/docs/tasks/run/multikueue/job.md Co-authored-by: Yuki Iwai <[email protected]> --------- Co-authored-by: Yuki Iwai <[email protected]>
This reverts commit 4e45d4c.
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.61.0 to 1.62.0. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.61.0...v1.62.0) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oup (kubernetes-sigs#3500) Bumps the all group with 1 update: [rajatjindal/krew-release-bot](https://github.com/rajatjindal/krew-release-bot). Updates `rajatjindal/krew-release-bot` from 0.0.46 to 0.0.47 - [Release notes](https://github.com/rajatjindal/krew-release-bot/releases) - [Changelog](https://github.com/rajatjindal/krew-release-bot/blob/main/.goreleaser.yml) - [Commits](rajatjindal/krew-release-bot@v0.0.46...v0.0.47) --- updated-dependencies: - dependency-name: rajatjindal/krew-release-bot dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…3498) * propogate time.Time into ResetChecksOnEviction * propogate time.Time into SetAdmissionCheckState * make changes to workloadInfo * remove clock field from workloadInfo struct * remove unused vars and fields * add options to newWlReconciler * add realClock and clock field to Controller back * use now inside TestWlReconcile * fix lint errors * revert changes on ResetChecksOnEviction * replace more time.Now() with clock.Now() in workload * remove unused argument * add clock.Now to NewTime * replace time.Now in FirstReserving
….0 (kubernetes-sigs#3501) Bumps [github.com/open-policy-agent/cert-controller](https://github.com/open-policy-agent/cert-controller) from 0.11.0 to 0.12.0. - [Release notes](https://github.com/open-policy-agent/cert-controller/releases) - [Commits](open-policy-agent/cert-controller@v0.11.0...v0.12.0) --- updated-dependencies: - dependency-name: github.com/open-policy-agent/cert-controller dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…netes-sigs#3502) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.61.0 to 1.62.0. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.61.0...v1.62.0) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ubernetes-sigs#3503) Bumps [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind) from 0.24.0 to 0.25.0. - [Release notes](https://github.com/kubernetes-sigs/kind/releases) - [Commits](kubernetes-sigs/kind@v0.24.0...v0.25.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kind dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…s#3504) Bumps [github.com/gohugoio/hugo](https://github.com/gohugoio/hugo) from 0.136.5 to 0.138.0. - [Release notes](https://github.com/gohugoio/hugo/releases) - [Changelog](https://github.com/gohugoio/hugo/blob/master/hugoreleaser.toml) - [Commits](gohugoio/hugo@v0.136.5...v0.138.0) --- updated-dependencies: - dependency-name: github.com/gohugoio/hugo dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…etes-sigs#3505) Bumps [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind) from 0.24.0 to 0.25.0. - [Release notes](https://github.com/kubernetes-sigs/kind/releases) - [Commits](kubernetes-sigs/kind@v0.24.0...v0.25.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kind dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove visibility API v1alpha1. * Remove v1alpha1.visibility.kueue.x-k8s.io APIService.
* [kjobctl] Skip kueue labels on child objects. * Use strictNaming argument on buildObjectMeta.
* reset admission check after deactivation Signed-off-by: Kevin <[email protected]> * adjust unit tests Signed-off-by: Kevin <[email protected]> * use deactivation as prefix Signed-off-by: Kevin <[email protected]> * use realClock in admissionCheck package Signed-off-by: Kevin <[email protected]> * remove rejected check because it's transitory Signed-off-by: Kevin <[email protected]> * swap order to avoid short circuit Signed-off-by: Kevin <[email protected]> * dont duplicate eviction function Signed-off-by: Kevin <[email protected]> * address comments Signed-off-by: Kevin <[email protected]> * add unit test for admission check reset Signed-off-by: Kevin <[email protected]> * adjust test description to reflect transitory nature Signed-off-by: Kevin <[email protected]> --------- Signed-off-by: Kevin <[email protected]>
* fix: nodelabels in tas's sample are incorrenct * Update site/static/examples/tas/sample-queues.yaml Co-authored-by: Michał Woźniak <[email protected]> --------- Co-authored-by: Michał Woźniak <[email protected]>
…gs#3517) * Add example using helm repo to helm installation guide * Update charts/kueue/README.md Co-authored-by: Mykhailo Bobrovskyi <[email protected]> * Add kueue README.md to version replace sed * Fix sed replace for kueue helm readme * Remove kueue readme from other sed --------- Co-authored-by: Mykhailo Bobrovskyi <[email protected]>
…3514) * TAS: fix computing assignment when multiple PodSets * review remarks
* Remove kubernetes 1.27 * Remove `CanSupportIntegration` in pod controller. * Fix after rebase --------- Co-authored-by: Traian Schiau <[email protected]>
…gs#3489) * Introduce TAS test-infra * Add first e2e tests * Add resource limit to job wrapper * Add TAS e2e target for test-infra * Update after code review
Signed-off-by: Kevin <[email protected]>
The following users havent contributed in the recent past. Moving to emeritus approvers. - anishasthana - jbusche - maxusmusti - tedhtchang Signed-off-by: Anish Asthana <[email protected]>
…g and mutating webhooks to interfere with system jobs
Signed-off-by: Varsha Prasad Narsing <[email protected]>
Signed-off-by: Kevin <[email protected]>
VAP is a default admission plugin enabled while starting an API server for visibility. The Kueue controller has additional permissions to watch those GVKs even though it is not required. Disabling the plugin from api server helps in keeping it minimal and maintaining compatibility with previous versions of K8s. Signed-off-by: Varsha Prasad Narsing <[email protected]>
* Remove deprecated kube-rbac-proxy. * Bump limit for controller manager.
Signed-off-by: Kevin <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@KPostOffice: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
CI needs 1.23 to be present in golang image. I've opened a PR with the updated CI here |
ChristianZaccaria
force-pushed
the
dev
branch
from
ce05603 to
22d4e3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?