Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release 0.26.0 #851

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codeflare-machine-account
Copy link
Contributor

🚀 This is an automated Pull Request generated by odh-notebooks-sync.yml workflow.

This PR updates the Pipfile to sync with latest Codeflare-SDK release.

@openshift-ci openshift-ci bot requested review from dibryant and jstourac January 21, 2025 12:18
@jiridanek
Copy link
Member

the images are building,
/approve

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member

/lgtm
/retest

@jstourac
Copy link
Member

jstourac commented Jan 22, 2025

What is the target release version here? Does this have to go to RHOAI 2.17 or not?

https://github.com/project-codeflare/codeflare-sdk/actions/runs/12886596842

@oksanabaza
Copy link

What is the target release version here? Does this have to go to RHOAI 2.17 or not?

https://github.com/project-codeflare/codeflare-sdk/actions/runs/12886596842

Hey, no, its not for RHOAI 2.17, it can go in the next release

@jiridanek
Copy link
Member

Error: received unexpected terminate signal
INFO[2025-01-22T11:02:39Z] Ran for 3h23m14s                             
ERRO[2025-01-22T11:02:39Z] Some steps failed: 

looks like resources/timing issue
/override ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror

Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror

In response to this:

Error: received unexpected terminate signal
INFO[2025-01-22T11:02:39Z] Ran for 3h23m14s                             
ERRO[2025-01-22T11:02:39Z] Some steps failed: 

looks like resources/timing issue
/override ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

@codeflare-machine-account: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror b24f5b2 link true /test notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
ci/prow/images b24f5b2 link true /test images
ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror b24f5b2 link true /test notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror
ci/prow/rocm-runtimes-ubi9-e2e-tests b24f5b2 link true /test rocm-runtimes-ubi9-e2e-tests
ci/prow/notebooks-ubi9-e2e-tests b24f5b2 link true /test notebooks-ubi9-e2e-tests
ci/prow/rocm-notebooks-e2e-tests b24f5b2 link true /test rocm-notebooks-e2e-tests
ci/prow/runtimes-ubi9-e2e-tests b24f5b2 link true /test runtimes-ubi9-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants