Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix vue-tsc type checking errors #309

Closed
abulte opened this issue Dec 25, 2023 · 4 comments · Fixed by #409
Closed

fix vue-tsc type checking errors #309

abulte opened this issue Dec 25, 2023 · 4 comments · Fixed by #409
Assignees
@abulte
Labels
refactor Evolutions du code sans impact sur le produit

Comments

@abulte
Copy link
Contributor

abulte commented Dec 25, 2023 

npm i -D vue-toc
npx vue-tsc --noEmit

Found 135 errors in 13 files.

Errors  Files
     2  src/components/DiscussionsList.vue:57
     1  src/components/header/Header.vue:11
     4  src/custom/ecospheres/components/BouquetDatasetList.vue:11
     1  src/custom/ecospheres/components/BouquetList.vue:111
     2  src/custom/ecospheres/components/BouquetSearch.vue:83
     3  src/custom/ecospheres/components/forms/bouquet/BouquetFormRecap.vue:18
     4  src/custom/ecospheres/components/forms/bouquet/BouquetPropertiesFieldGroup.vue:10
     2  src/custom/ecospheres/components/forms/bouquet/BouquetThemeFieldGroup.vue:89
     1  src/custom/ecospheres/components/forms/dataset/DatasetPropertiesForm.vue:140
    22  src/custom/ecospheres/views/bouquets/BouquetDetailView.vue:51
     7  src/custom/ecospheres/views/bouquets/BouquetEditView.vue:103
    37  src/custom/meteo/views/FormMF.vue:19
    49  src/views/datasets/DatasetDetailView.vue:43

NB: tsc --no-emit runs fine since #304, but does not check TS vue components.
@abulte abulte changed the title fix vue-tsc errors fix vue-tsc type checking errors Dec 25, 2023
@abulte abulte mentioned this issue Dec 25, 2023
Merged
12 tasks
@abulte abulte mentioned this issue Jan 2, 2024
Merged
@abulte
Copy link
Contributor Author

abulte commented Jan 2, 2024

#311

Found 107 errors in 10 files.

Errors  Files
     1  src/components/header/Header.vue:11
     3  src/custom/ecospheres/components/BouquetDatasetList.vue:11
     1  src/custom/ecospheres/components/BouquetList.vue:111
     2  src/custom/ecospheres/components/BouquetSearch.vue:83
     3  src/custom/ecospheres/components/forms/bouquet/BouquetFormRecap.vue:18
     4  src/custom/ecospheres/components/forms/bouquet/BouquetPropertiesFieldGroup.vue:10
     2  src/custom/ecospheres/components/forms/bouquet/BouquetThemeFieldGroup.vue:89
     7  src/custom/ecospheres/views/bouquets/BouquetEditView.vue:103
    37  src/custom/meteo/views/FormMF.vue:19
    47  src/views/datasets/DatasetDetailView.vue:41

@abulte abulte mentioned this issue Jan 3, 2024
Merged
@abulte
Copy link
Contributor Author

abulte commented Jan 3, 2024

#312

Found 91 errors in 6 files.

Errors  Files
     1  src/components/header/Header.vue:11
     1  src/custom/ecospheres/components/BouquetList.vue:111
     2  src/custom/ecospheres/components/BouquetSearch.vue:83
     3  src/custom/ecospheres/components/forms/bouquet/BouquetFormRecap.vue:18
    37  src/custom/meteo/views/FormMF.vue:19
    47  src/views/datasets/DatasetDetailView.vue:41

@abulte abulte mentioned this issue Jan 3, 2024
Merged
@abulte
Copy link
Contributor Author

abulte commented Jan 3, 2024 •
edited
Loading

#313

Found 85 errors in 3 files.

Errors  Files
     1  src/components/header/Header.vue:11
    37  src/custom/meteo/views/FormMF.vue:19
    47  src/views/datasets/DatasetDetailView.vue:41

@abulte abulte self-assigned this Jan 3, 2024
@abulte abulte added the refactor Evolutions du code sans impact sur le produit label Feb 22, 2024
@abulte abulte mentioned this issue Apr 2, 2024
Merged
@abulte
Copy link
Contributor Author

abulte commented Apr 2, 2024

#408

NB: latest vue-tsc does not output errors anymore, except in watch mode 🤔

$ npx [email protected] --noEmit

Found 44 errors in 3 files.

Errors  Files
     1  src/components/header/Header.vue:11
     1  src/custom/ecospheres/views/bouquets/BouquetEditView.vue:204
    42  src/custom/meteo/views/FormMF.vue:22

@abulte abulte moved this to 🏗 In progress in Ecosphères Apr 2, 2024
abulte added a commit that referenced this issue Apr 2, 2024
@abulte
chore: fix #309 ts in vue components
5c8a8ab
@abulte abulte mentioned this issue Apr 2, 2024
Merged
abulte added a commit that referenced this issue Apr 3, 2024
@abulte
chore: fix #309 ts in vue components
afee10b
@abulte abulte moved this from 🏗 In progress to 👀 In review in Ecosphères Apr 3, 2024
@abulte abulte mentioned this issue Apr 15, 2024
Merged
abulte added a commit that referenced this issue Apr 17, 2024
@abulte
chore: fix #309 ts in vue components
318c0db
@abulte abulte moved this from 👀 In review to ✅ Done in Ecosphères Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abulte abulte

Labels
refactor Evolutions du code sans impact sur le produit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: typescript components syntax opendatateam/udata-front-kit
1 participant
@abulte