Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript components syntax #409

Merged
merged 2 commits into from
Apr 18, 2024
Merged

fix: typescript components syntax #409

merged 2 commits into from
Apr 18, 2024

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Apr 2, 2024

Fix #309

  • Corrige les erreurs Typescript dans les composants TS.
  • Ajoute un check CI pour éviter les régressions

Gros refactor de FormMF, testé rapidement, @geoffreyaldebert je te laisse vérifier !

@nicolaskempf57 si tu as une idée pour vue-tsc, impossible de le faire marcher en 2.x 🤔

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for meteo-france ready!

Name Link
🔨 Latest commit 8f7eacd
🔍 Latest deploy log https://app.netlify.com/sites/meteo-france/deploys/661fffb62d18180008d657b2
😎 Deploy Preview https://deploy-preview-409--meteo-france.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for ecospheres ready!

Name Link
🔨 Latest commit 8f7eacd
🔍 Latest deploy log https://app.netlify.com/sites/ecospheres/deploys/661fffb6b9a82c00096727d5
😎 Deploy Preview https://deploy-preview-409--ecospheres.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abulte abulte changed the title Fix/vue tsc fix: typescript components syntax Apr 3, 2024
@abulte abulte marked this pull request as ready for review April 3, 2024 10:02
@streino
Copy link
Contributor

streino commented Apr 3, 2024

Comme on est majoritairement sur du MF je laisse @geoffreyaldebert @nicolaskempf57 confirmer que c'est ok

@nicolaskempf57
Copy link
Contributor

@abulte vue-tsc v2 a l'air de fonctionner en séparant le fichier tsconfig.json en 2 (un pour vite et un pour le projet, comme dans les nouveaux templates vite)

@abulte abulte mentioned this pull request Apr 5, 2024
@abulte
Copy link
Contributor Author

abulte commented Apr 5, 2024

@nicolaskempf57 j'ai essayé avec un projet from scratch depuis les templates mais pas mieux :-/ En revanche les dernières (au moins 2.0.10) semblent régler le problème sur ce dépôt cf https://github.com/opendatateam/udata-front-kit/actions/runs/8567991548/job/23480917677?pr=409

@abulte
Copy link
Contributor Author

abulte commented Apr 5, 2024

@geoffreyaldebert la balle est dans ton camp 🏉

@abulte abulte added the refactor Evolutions du code sans impact sur le produit label Apr 13, 2024
@abulte
Copy link
Contributor Author

abulte commented Apr 17, 2024

@maudetes @nicolaskempf57 possible de passer ça assez rapidement ? 🙏 🐱 🐭 🕺

Copy link
Contributor

@nicolaskempf57 nicolaskempf57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! This is working great 🙏🏻

@abulte abulte merged commit e75c982 into main Apr 18, 2024
7 checks passed
@abulte abulte deleted the fix/vue-tsc branch April 18, 2024 07:51
nicolaskempf57 pushed a commit that referenced this pull request Apr 18, 2024
fix: typescript components syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Evolutions du code sans impact sur le produit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix vue-tsc type checking errors
3 participants