-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(indicators): detail page #643
Conversation
✅ Deploy Preview for ecospheres ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for meteo-france ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surtout des questions et des petites suggestions !
src/custom/ecospheres/components/indicators/IndicatorAPIDocumentation.vue
Outdated
Show resolved
Hide resolved
src/custom/ecospheres/components/indicators/SelectSpatialGranularity.vue
Outdated
Show resolved
Hide resolved
src/custom/ecospheres/components/indicators/SelectSpatialGranularity.vue
Outdated
Show resolved
Hide resolved
src/custom/ecospheres/components/indicators/informations/InformationPanelItem.vue
Outdated
Show resolved
Hide resolved
src/custom/ecospheres/components/indicators/informations/InformationPanelSection.vue
Outdated
Show resolved
Hide resolved
…mationPanelSection.vue Co-authored-by: Nico <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le "non renseigné" n'est pas appliqué pour "Mailles". Peut-être à cause du join
?
Il n'y a pas de message "vide" pour les onglets "Fichiers et API" et "sources". Sur cet indicateur en particulier, la hauteur des onglets reste fixe. |
Peut-être à revoir plus tard, mais dans la vraie vie ce n'est pas censé arriver (particulièrement pas de fichier). Les données de test actuelles sont vraiment de mauvaise qualité, sauf 678588df9cf785da8e0bba65. Je ne passerais pas trop de temps à gérer des cas particuliers qui n'arriveront pas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testé PO OK
Fix ecolabdata/ecospheres#466