This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
Remove ods preview #246
Open
Remove ods preview #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close datagouv/data.gouv.fr#1063
By removing ODS preview, our custom tabular preview gets used instead.
However, tabular preview requires a filesize lower than a threshold but ODS resources don't have any
filesizeharvested (this information is not exposed by ODS).Only if the resource has been crawled by linkchecker in the past or has been crawled by new hydra crawler and has an extra
check:headers:content-lengthlower than a threshold, it can be previewed and explored.