Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix error banner alert #1180

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

syedsajjadkazmii
Copy link
Contributor

Description

Removing error alert banner on clicking submit button with valid data.

How Has This Been Tested?

Locally

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@syedsajjadkazmii syedsajjadkazmii requested a review from a team as a code owner February 29, 2024 07:08
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 84.22%. Comparing base (80435d3) to head (6764daa).

Files Patch % Lines
src/register/RegistrationPage.jsx 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1180      +/-   ##
==========================================
- Coverage   84.33%   84.22%   -0.11%     
==========================================
  Files         127      127              
  Lines        2400     2403       +3     
  Branches      682      683       +1     
==========================================
  Hits         2024     2024              
- Misses        356      359       +3     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syedsajjadkazmii syedsajjadkazmii merged commit 8aeacaa into master Feb 29, 2024
5 of 7 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the sajjad/VAN-1827-fix-error-alert branch February 29, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants