-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add AdvancedEditors with an iframe [FC-0076] #1568
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @ChrisChV! This repository is currently maintained by @openedx/2u-tnl. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1568 +/- ##
==========================================
+ Coverage 92.94% 93.08% +0.13%
==========================================
Files 1073 1093 +20
Lines 21098 21643 +545
Branches 4479 4582 +103
==========================================
+ Hits 19610 20146 +536
- Misses 1422 1431 +9
Partials 66 66 ☔ View full report in Codecov by Sentry. |
c547d84
to
c0f84ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: Ran the testing instructions
- I read through the code
- I checked for accessibility issues
- Includes documentation
When I edit a drag and drop, it doesn't refresh in the preview until I refresh the page. And the card in the search results never updated at all. Is this just a proof of concept or do you want to merge this now? If so, we need to fix that first. |
@bradenmacdonald Fixed with the new changes in openedx/edx-platform#36029
I prefer to merge it now to have a good base to work on and fix bugs specific to each block. |
Description
Creates the
AdvancedEditor
to support editors like Drag and Drop, openresponse, poll, survey, and other advanced editors.Follow this discovery for next steps.
AdvancedEditor
created to callstudio_view
of the blockLibraryBlock
to support any view (and usestudio_view
inAdvancedEditor
)xblock-event
message to close the Advanced editor on cancel or saveUseful information to include:
Supporting information
Testing instructions
LIBRARY_SUPPORTED_BLOCKS="problem,video,html,poll,drag-and-drop-v2,lti_consumer,google-document,survey"
in.env.development
Advanced module list
add:Other information
N/A