Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow user provided value if can auto-create orgs [FC-0076] #1582

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pomegranited
Copy link
Contributor

@pomegranited pomegranited commented Jan 10, 2025

Description

Allows Content Authors to auto-create an organization when creating a library, if auto-creating orgs is allowed by the platform.

Org.autocreate.-.Made.with.Clipchamp.mp4

Supporting information

Part of: #1577
Depends on: openedx/edx-platform#36094 <-- this PR must be merged first.

Testing instructions

  1. Install branch from fix: allow_to_create_new_org checks org autocreate [FC-0076] edx-platform#36094

With cms settings.ORGANIZATIONS_AUTOCREATE = True (default):

  1. Visit http://apps.local.openedx.io:2001/authoring/library/create
  2. Fill in the form using an organization that does not exist in the available list, e.g. NewOrg
  3. Click "Create"
    Should redirect to the new library's page and auto-create the organization.

With cms settings.ORGANIZATIONS_AUTOCREATE = False:

  1. Visit http://apps.local.openedx.io:2001/authoring/library/create
  2. Fill in the form using an organization that does not exist in the available list, e.g. NewOrg2
  3. Click "Create"
    Should not allow the library (or organization) to be created, and instead show "Required field" under the Organization field.

Author Notes & Concerns:

  1. My initial approach refactored the code used by the "Create Course" form into a shared OrganizationField. which I then modified to use Form.Autosuggest instead of Dropdown to preserve "Create Library"'s auto-complete functionality.
    This works fine, but was a bigger change, so I decided against it.

@pomegranited pomegranited requested a review from a team as a code owner January 10, 2025 07:23
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 10, 2025

Thanks for the pull request, @pomegranited!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.08%. Comparing base (f586b09) to head (552ffcc).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1582      +/-   ##
==========================================
+ Coverage   92.97%   93.08%   +0.10%     
==========================================
  Files        1075     1092      +17     
  Lines       21205    21625     +420     
  Branches     4576     4661      +85     
==========================================
+ Hits        19715    20129     +414     
- Misses       1418     1424       +6     
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@navinkarkera
Copy link
Contributor

@pomegranited The test was fixed once I used async version of getByRole etc., the userevent was probably not being fired at correct time consistently.

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jan 13, 2025
Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good! @pomegranited

  • I tested this: (Tried creating org via new lib page and course page)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@pomegranited pomegranited requested a review from ChrisChV January 15, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: In Eng Review
Development

Successfully merging this pull request may close these issues.

4 participants