Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: implement sketch models and api for interactions based on 0017/18 #254
base: main
Are you sure you want to change the base?
[WIP] feat: implement sketch models and api for interactions based on 0017/18 #254
Changes from 5 commits
8239985
b9fed67
149c480
3780e49
1f10aec
d9cdb21
dc57c10
1ad12f5
5d0083b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question:
Should the draft/published versions be derived somehow from the publishable entities?
This is still under discussion in the ADR, so we'll probably use a single reference to the versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self:
This is pinning references for the next version of the container instead of pinning versions for the previous version. Which is what should happen according to this comment: https://github.com/openedx/openedx-learning/pull/254/files#diff-6f2c589dc4ba5960e91d39f6488eb5e2e2e63ddaff63a75909091c760b877802R142-R147
So, when have two scenarios when creating a new version:
The author defined list has unpinned references
The author defined list has pinned references
And any other combination between the two in case defined_list can pin/unpin references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self:
Here, I'm creating a new
defined_list
(with new rows) for each new version and also copying things over from the previouslydefined_list
into a newfrozen_list
(also, with new rows). This is done to comply with:defined_list
should never change for a given ContainerEntityVersion to simplify reasoning.But we also have this requirement:
So no new entity list rows for
defined_lists
should be created if the ordering doesn't change or versions are not pinned, but new members are added. Which I'm currently not considering.I remember discussing this with Dave a couple of weeks ago too, so implementing it seems like the right approach here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm testing my changes out before pushing, I'm hoping I can do it today.