Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed cached_result to be compatible with new QCPortal #40

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Changed cached_result to be compatible with new QCPortal #40

merged 1 commit into from
Apr 9, 2024

Conversation

amcisaac
Copy link
Contributor

@amcisaac amcisaac commented Apr 9, 2024

Fixes #38

@amcisaac amcisaac requested review from mattwthompson and ntBre April 9, 2024 18:48
mattwthompson
mattwthompson approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@mattwthompson mattwthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #40 (975d722) into main (98f9a50) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

@mattwthompson
Copy link
Member

Probably don't need to wait for the macOS runners to catch up - if this change manifests an OS difference, we've got bigger problems

@mattwthompson mattwthompson merged commit 91b1ae1 into main Apr 9, 2024
4 checks passed
@mattwthompson mattwthompson deleted the fix_cache branch November 25, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntBre ntBre ntBre approved these changes

@mattwthompson mattwthompson mattwthompson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Caching code written for old QCPortal
4 participants
@amcisaac @codecov-commenter @mattwthompson @ntBre