Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make molecules from SMILES where possible #46

Merged
merged 5 commits into from
May 8, 2024

Conversation

mattwthompson
Copy link
Member

Might resolve #45

@mattwthompson mattwthompson force-pushed the make-molecules-from-smiles branch from 154fd7a to de8b563 Compare May 7, 2024 15:41
@mattwthompson mattwthompson force-pushed the make-molecules-from-smiles branch from de8b563 to b65e410 Compare May 7, 2024 15:48
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.97%. Comparing base (09720ba) to head (1f19944).

Additional details and impacted files

@mattwthompson
Copy link
Member Author

Based on #45 this fixes most or all of the issues with TFD discrepancies and some issues with internal coordinate RMSDs

@mattwthompson mattwthompson merged commit f87fd45 into main May 8, 2024
5 checks passed
@mattwthompson mattwthompson deleted the make-molecules-from-smiles branch November 25, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent atom order between Molecule.from_mapped_smiles and Molecule.from_inchi affecting TFD results
3 participants