Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graylog service #147

Closed
wants to merge 1 commit into from
Closed

Conversation

quitterie-lcs
Copy link
Contributor

@quitterie-lcs quitterie-lcs commented Sep 29, 2021

Purpose

LDP backends is available for tests.But until now, no service was available in the project.

Proposal

  • add docker-compose service
  • add Makefile rule
  • add backend
  • add push functionality in backend
  • add fetch functionality in backend
  • add tests for graylog backend
  • add logging backend documentation

@quitterie-lcs quitterie-lcs force-pushed the backends-add-graylog-service branch 2 times, most recently from f368ea9 to c5aee65 Compare September 29, 2021 13:33
@quitterie-lcs quitterie-lcs self-assigned this Sep 29, 2021
Makefile Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
.env.dist Outdated Show resolved Hide resolved
src/ralph/backends/storage/graylog.py Outdated Show resolved Hide resolved
src/ralph/backends/storage/graylog.py Outdated Show resolved Hide resolved
@quitterie-lcs quitterie-lcs force-pushed the backends-add-graylog-service branch from a9c618d to daa459d Compare October 14, 2021 15:29
@quitterie-lcs quitterie-lcs force-pushed the backends-add-graylog-service branch 5 times, most recently from c68144f to e995c39 Compare November 3, 2021 17:22
@quitterie-lcs quitterie-lcs force-pushed the backends-add-graylog-service branch 2 times, most recently from 02ac0fc to b7a07c6 Compare November 22, 2021 15:49
@quitterie-lcs quitterie-lcs marked this pull request as ready for review November 23, 2021 10:31
@quitterie-lcs quitterie-lcs force-pushed the backends-add-graylog-service branch 4 times, most recently from 2dc2e83 to 8d20434 Compare November 30, 2021 08:48
Copy link
Contributor

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💪

Remarks:

  1. Instructions to run/access the graylog server are missing in the project's README
  2. Should we pre-configure the graylog server in development (create and activate inputs, create streams)?

setup.cfg Outdated Show resolved Hide resolved
src/ralph/backends/logging/graylog.py Outdated Show resolved Hide resolved
src/ralph/backends/logging/graylog.py Outdated Show resolved Hide resolved
src/ralph/backends/logging/graylog.py Show resolved Hide resolved
src/ralph/backends/logging/graylog.py Outdated Show resolved Hide resolved
src/ralph/defaults.py Outdated Show resolved Hide resolved
src/ralph/backends/logging/graylog.py Show resolved Hide resolved
tests/backends/logging/test_graylog.py Outdated Show resolved Hide resolved
tests/backends/logging/test_graylog.py Outdated Show resolved Hide resolved
tests/backends/logging/test_graylog.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@SergioSim SergioSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work!
Have only minor suggestions.

src/ralph/backends/logging/graylog.py Outdated Show resolved Hide resolved
.env.dist Show resolved Hide resolved
src/ralph/backends/logging/base.py Outdated Show resolved Hide resolved
src/ralph/backends/logging/graylog.py Show resolved Hide resolved
tests/backends/logging/test_graylog.py Outdated Show resolved Hide resolved
tests/backends/logging/test_graylog.py Outdated Show resolved Hide resolved
@quitterie-lcs quitterie-lcs force-pushed the backends-add-graylog-service branch 2 times, most recently from 7bccd8f to ef36d57 Compare December 30, 2021 15:07
src/ralph/backends/logging/graylog.py Show resolved Hide resolved
src/ralph/backends/logging/graylog.py Outdated Show resolved Hide resolved
src/ralph/backends/logging/graylog.py Outdated Show resolved Hide resolved
src/ralph/backends/logging/graylog.py Outdated Show resolved Hide resolved
src/ralph/backends/logging/graylog.py Outdated Show resolved Hide resolved
src/ralph/backends/logging/graylog.py Show resolved Hide resolved
src/ralph/backends/logging/graylog.py Outdated Show resolved Hide resolved
src/ralph/backends/logging/graylog.py Show resolved Hide resolved
src/ralph/backends/logging/graylog.py Show resolved Hide resolved
def search_logs(self, params):
"""Returns logs matching given `params` parameters."""

return self.get("/api/search/universal/relative", params=params)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not found documentation for this endpoint. Can you point me to it?

@quitterie-lcs quitterie-lcs force-pushed the backends-add-graylog-service branch 2 times, most recently from 1afe63e to aa1eda6 Compare March 24, 2022 13:27
@quitterie-lcs quitterie-lcs marked this pull request as draft March 25, 2022 10:50
@quitterie-lcs quitterie-lcs force-pushed the backends-add-graylog-service branch from aa1eda6 to 66e11f8 Compare August 18, 2022 09:28
@quitterie-lcs quitterie-lcs force-pushed the backends-add-graylog-service branch from 66e11f8 to e360c46 Compare August 18, 2022 13:21
@wilbrdt wilbrdt mentioned this pull request Oct 19, 2023
@wilbrdt
Copy link
Contributor

wilbrdt commented Oct 19, 2023

Opened issue #475 and closing this PR as it is too far from master branch.

@wilbrdt wilbrdt closed this Oct 19, 2023
@quitterie-lcs quitterie-lcs deleted the backends-add-graylog-service branch November 28, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants