Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345337: JFR: jfr view should display all direct subfields for an event type #23009

Closed

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Jan 9, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345337: JFR: jfr view should display all direct subfields for an event type (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23009/head:pull/23009
$ git checkout pull/23009

Update a local copy of the PR:
$ git checkout pull/23009
$ git pull https://git.openjdk.org/jdk.git pull/23009/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23009

View PR using the GUI difftool:
$ git pr show -t 23009

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23009.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2025

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345337: JFR: jfr view should display all direct subfields for an event type

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk24 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 672c413c61d9b155020a0fd4bd1c2bc0661a60fb 8345337: JFR: jfr view should display all direct subfields for an event type Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@egahlin egahlin marked this pull request as ready for review January 9, 2025 14:57
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2025

Webrevs

@egahlin
Copy link
Member Author

egahlin commented Jan 10, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

Going to push as commit c61fbfd.
Since your change was applied there have been 5 commits pushed to the jdk24 branch:

  • 92a4e23: 8346838: RISC-V: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java crash with debug VMs
  • ba36d30: 8332506: SIGFPE In ObjectSynchronizer::is_async_deflation_needed()
  • 41630c5: 8347127: CTW fails to build after JDK-8334733
  • 864d0fd: 8347289: HKDF delayed provider selection failed with non-extractable PRK
  • ff9b8e4: 8346737: GenShen: Generational memory pools should not report zero for maximum capacity

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2025
@openjdk openjdk bot closed this Jan 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2025
@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@egahlin Pushed as commit c61fbfd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants