8347146: Convert IncludeLocalesPluginTest to use JUnit #23016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Webrevs
|
justin-curtis-lu
approved these changes
Jan 9, 2025
| @@ -424,47 +414,43 @@ public static void main(String[] args) throws Exception { | |||
|
|
|||
| helper = Helper.newHelper(isLinkableRuntime); | |||
| if (helper == null) { | |||
| throw new RuntimeException("Helper could not be initialized"); | |||
| fail("Helper could not be initialized"); | |||
There was a problem hiding this comment.
Could be assertNotNull, but probably best to not use an assertion in the setup method.
There was a problem hiding this comment.
Replaced with assertion here, and one other location. I think it is fine
justin-curtis-lu
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple refinement to the test makes diagnosing failures easier.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23016/head:pull/23016$ git checkout pull/23016Update a local copy of the PR:
$ git checkout pull/23016$ git pull https://git.openjdk.org/jdk.git pull/23016/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23016View PR using the GUI difftool:
$ git pr show -t 23016Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23016.diff
Using Webrev
Link to Webrev Comment