8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x

[vieiro]

A clean backport of JDK-8294316 to properly parse core files in macOS 12 and later. Load commands with length zero are now discarded.

The fix doesn't affect directly to SA tests in 21, but it's being backported to 11 as this is the cause of an older version of serviceability/sa/ClhsdbFindPC.java failing in JDK 11 on macos-13 GHA runners.

Tests in 21 continue to pass in all platforms, including macos.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8294316 needs maintainer approval

Issue

• JDK-8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1227/head:pull/1227
$ git checkout pull/1227

Update a local copy of the PR:
$ git checkout pull/1227
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1227/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1227

View PR using the GUI difftool:
$ git pr show -t 1227

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1227.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vieiro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

• cce9336: 8316371: Open some swing tests 6
• 0cdb868: 8316218: Open some swing tests 5
• 0cb7705: 8316146: Open some swing tests 4
• 85453b6: 8315882: Open some swing tests 2
• e1b5f3c: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file
• 30eeb80: 8341978: Improve JButton/bug4490179.java
• dbf6f67: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1
• 6a2ef78: 8339902: Open source couple TextField related tests
• e8842b7: 8339687: Rearrange reachabilityFence()s in jdk.test.lib.util.ForceGC
• c609fe5: 8336692: Redo fix for JDK-8284620
• ... and 62 more: https://git.openjdk.org/jdk21u-dev/compare/50fc231b04c0e97d74ad2d6bb97096d924bd3f0f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (38927c6f)

[vieiro]

/approval request This improves macos core files parsing. The plan is to backport this to 11 to make an older version of serviceability/sa/ClhsdbFindPC.java to pass with minimum impact.

[openjdk]

@vieiro
8294316: The approval request has been created successfully.

[vieiro]

Build failures are unrelated and are due to downloads of ant binaries not complying with the archive.apache.org ban policies

[build.sh][INFO] Downloading https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.8-bin.zip to /home/runner/work/jdk21u-dev/jdk21u-dev/jtreg/src/make/../build/deps/apache-ant-1.10.8-bin.zip
Error: sh][ERROR] wget exited with exit code 4
Error: Process completed with exit code 1.

[vieiro]

/integrate

[openjdk]

@vieiro
Your change (at version 38927c6) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit eaa475f.
Since your change was applied there have been 77 commits pushed to the master branch:

• 227c430: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform
• 1c53e8c: 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main
• c0336dd: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
• 0a65f3c: 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main
• 57973b7: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
• cce9336: 8316371: Open some swing tests 6
• 0cdb868: 8316218: Open some swing tests 5
• 0cb7705: 8316146: Open some swing tests 4
• 85453b6: 8315882: Open some swing tests 2
• e1b5f3c: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file
• ... and 67 more: https://git.openjdk.org/jdk21u-dev/compare/50fc231b04c0e97d74ad2d6bb97096d924bd3f0f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @vieiro Pushed as commit eaa475f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.