Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make editor find case insensitive #1351

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Make editor find case insensitive #1351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/paper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ def review_body(editor, reviewers, branch=nil)
# Return false if the editor login doesn't match one of the known editors
def create_review_issue(editor_handle, reviewers, branch=nil)
return false if review_issue_id
return false unless editor = Editor.find_by_login(editor_handle)
return false unless editor = Editor.where("lower(login) = ?", editor_handle.downcase).first

if labels.any?
new_labels = labels.keys + ["review"] - ["pre-review"]
Expand Down