fix authors with periods in names #1357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1346
The problem was that names with periods in them were interpreted as being a file extension (perhaps reasonably?) by the router. So clicking on
"Author T. Lastname"
in a paper would be interpreted by rails as{author: "Author T", format: " Lastname"}
So i added a constraint that matches any string excluding the three formats that it looks like there were responders for and added tests - don't know if i put the tests in the right spot, there weren't any tests for the
papers/by/:author
route so i just put it with the controller.edit: i find ruby's formatting norms to be bewildering and bad, and i didn't notice a linter config in this repo, so sorry if my indentation is weird, feel free to request edits.