fix: cannot cache last validated data, since it might change after up…

…date
openlawlibrary · Dec 4, 2024 · 82bf67b · 82bf67b
1 parent 20a1142
commit 82bf67b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/taf/auth_repo.py b/taf/auth_repo.py
@@ -27,7 +27,6 @@ class AuthenticationRepository(GitRepository, TAFRepository):
 
     _conf_dir = None
     _dependencies: Dict = {}
-    _last_validated_data: Optional[Dict] = None
 
     def __init__(
         self,
@@ -154,18 +153,17 @@ def last_validated_data(self) -> Optional[dict]:
         """
         Return the last validated data of the authentication repository
         """
-        if self._last_validated_data is None:
-            last_validated_path = Path(self.conf_dir, self.LAST_VALIDATED_FILENAME)
-            self._last_validated_data = {}
-            if last_validated_path.is_file():
-                data = last_validated_path.read_text().strip()
-                try:
-                    self._last_validated_data = json.loads(data)
-                except json.decoder.JSONDecodeError:
-                    if data:
-                        self._last_validated_data = {self.name: data}
-
-        return self._last_validated_data
+        last_validated_data = {}
+        last_validated_path = Path(self.conf_dir, self.LAST_VALIDATED_FILENAME)
+        if last_validated_path.is_file():
+            data = last_validated_path.read_text().strip()
+            try:
+                last_validated_data = json.loads(data)
+            except json.decoder.JSONDecodeError:
+                if data:
+                    last_validated_data = {self.name: data}
+
+        return last_validated_data
 
     @property
     def log_prefix(self) -> str:

diff --git a/taf/updater/updater_pipeline.py b/taf/updater/updater_pipeline.py
@@ -490,7 +490,9 @@ def _set_last_validated_commit(self):
             # after a partial update, there is no need to validate the auth repo
             # from an older commit, just because one of more targets were skipped
             self.state.last_validated_data = users_auth_repo.last_validated_data
-            last_validated_commit = self.state.last_validated_data[users_auth_repo.name]
+            last_validated_commit = self.state.last_validated_data.get(
+                users_auth_repo.name
+            )
 
             settings.last_validated_commit[
                 self.state.validation_auth_repo.name