(refactor) O3-4221: Replace validation with zod

[Muppasanipraneeth]

Refactor(validation): O3-4221 Replace form validation with Zod

Requirements

• PR title includes conventional commit label and ticket number
• Conforms to OpenMRS 3.0 Styleguide and design documentation
• Includes tests validating the new Zod-based validation

Summary

This PR replaces the existing form validation approach with Zod, a TypeScript-first schema validation library. The key improvements include:

• More type-safe validation
• Simplified validation logic
• Better developer experience with inline schema definitions
• Reduced boilerplate code for form validation

Key changes:

• Introduced Zod schemas for form validation
• Replaced manual validation with schema-based validation
• Updated test cases to work with new validation approach

Screenshots

N/A - No UI changes, purely refactoring validation logic

Related Issue

https://issues.openmrs.org/browse/O3-4221

Other

• Minimal impact on existing component behavior
• Performance improvements through more efficient validation

[Muppasanipraneeth]

@denniskigen can you please review the changes

[NethmiRodrigo]

Please revert this back to next. Read here - https://o3-docs.openmrs.org/docs/frontend-modules/development#i-see-errors-about-missing-apis-when-i-run-the-app on instructions on how to update the core and framework, and importantly the step about checking out package.json when doing so.

[NethmiRodrigo]

Ditto

[NethmiRodrigo]

We don't need to do this, since this is jest does this as its set in the config by default-

openmrs-esm-patient-management/jest.config.js

Line 8 in f16bd73

clearMocks: true,

Suggested change

jest.clearAllMocks();

[NethmiRodrigo]

See this PR about partial mocks - openmrs/openmrs-esm-patient-chart#1933. But I'm confused as to why these require mocking for this test case, like the restBaseUrl?

Suggested change

	jest.mock('@openmrs/esm-framework', () => {
	return {
	showSnackbar: jest.fn(),
	restBaseUrl: '/ws/rest/v1',
	useLayoutType: jest.fn(),
	useExtensionSlot: jest.requireActual('@openmrs/esm-framework').useExtensionSlot,
	importDynamic: jest.fn(),
	};
	});
	jest.mock('@openmrs/esm-framework', () => ({
	...jest.requireActual('@openmrs/esm-framework'),
	showSnackbar: jest.fn(),
	restBaseUrl: '/ws/rest/v1',
	useLayoutType: jest.fn(),
	importDynamic: jest.fn(),
	}));

[NethmiRodrigo]

Why do we need to mock this?

[NethmiRodrigo]

Suggested change

	import * as z from 'zod';
	import { z } from 'zod';

[NethmiRodrigo]

This suggestion would require moving this inside the component definition itself so that it could use the t function.
@denniskigen looking at the other places where we've used zod in patient-management, we've done this in different ways, so I don't know if what I've suggested is the best way to go about this.

Suggested change

	const QueueServiceSchema = z.object({
	queueName: z.string().min(1, { message: 'Queue name is required' }),
	queueConcept: z.string().min(1, { message: 'Queue concept is required' }),
	userLocation: z.string().min(1, { message: 'Queue location is required' }),
	});
	const QueueServiceSchema = z.object({
	queueName: z.string({
	required_error: t('queueNameRequired', 'Queue name is required'),
	}),
	queueConcept: z.string({
	required_error: t('queueConceptRequired', 'Queue concept is required'),
	}),
	userLocation: z.string({
	required_error: t('queueLocationRequired', 'Queue location is required'),
	}),
	});

[NethmiRodrigo]

.then and showing the snackbar for success a .catch to catch the error afterwards should be sufficient, rather than checking for the status and doing an error inside the .then