Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-3836: Added a 'Add bed' button on the summary page of each location. #1433

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

UNCANNY69
Copy link

@UNCANNY69 UNCANNY69 commented Jan 9, 2025

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR enhances the bed-management-app by adding a "Add Bed" button to the summary page for each location. The functionality also includes setting the default active location.

Screenshots

image
image

Related Issue

https://issues.openmrs.org/browse/O3-3836

Other

Copy link
Contributor

@chibongho chibongho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Copy link
Collaborator

@NethmiRodrigo NethmiRodrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @UNCANNY69! Functionality works as intended, but I left some minor suggestions:

@@ -114,6 +118,25 @@ const WardWithBeds: React.FC = () => {
}>
<span>Return to summary</span>
</Button>
<span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this many parent spans?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants