Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Fix the translated texts having same key and different value strings #821

Merged
merged 11 commits into from
Oct 19, 2023
Merged

(fix) Fix the translated texts having same key and different value strings #821

merged 11 commits into from
Oct 19, 2023

Conversation

vasharma05
Copy link
Member

@vasharma05 vasharma05 commented Sep 27, 2023 •
edited by denniskigen
Loading

Requirements

Summary

This PR fixes the translated texts having same key and different value strings

Screenshots

None.

Related Issue

None.

Other

None.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023 •
edited
Loading

Size Change: +868 B (0%)

Total Size: 2.37 MB

ℹ️ View Unchanged
Filename Size Change
packages/esm-active-visits-app/dist/130.js 175 kB 0 B
packages/esm-active-visits-app/dist/316.js 42.9 kB 0 B
packages/esm-active-visits-app/dist/319.js 620 B 0 B
packages/esm-active-visits-app/dist/460.js 712 B 0 B
packages/esm-active-visits-app/dist/574.js 543 B 0 B
packages/esm-active-visits-app/dist/588.js 6.66 kB 0 B
packages/esm-active-visits-app/dist/629.js 7.48 kB 0 B
packages/esm-active-visits-app/dist/757.js 637 B 0 B
packages/esm-active-visits-app/dist/784.js 2.63 kB 0 B
packages/esm-active-visits-app/dist/788.js 540 B 0 B
packages/esm-active-visits-app/dist/807.js 856 B 0 B
packages/esm-active-visits-app/dist/833.js 660 B 0 B
packages/esm-active-visits-app/dist/842.js 890 B 0 B
packages/esm-active-visits-app/dist/879.js 2.94 kB 0 B
packages/esm-active-visits-app/dist/909.js 54.2 kB 0 B
packages/esm-active-visits-app/dist/936.js 7.97 kB 0 B
packages/esm-active-visits-app/dist/main.js 3.4 kB 0 B
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js 3.22 kB 0 B
packages/esm-appointments-app/dist/130.js 175 kB 0 B
packages/esm-appointments-app/dist/212.js 103 kB 0 B
packages/esm-appointments-app/dist/223.js 20.9 kB +6 B (0%)
packages/esm-appointments-app/dist/319.js 1.96 kB +86 B (+5%) 🔍
packages/esm-appointments-app/dist/328.js 11.6 kB -2 B (0%)
packages/esm-appointments-app/dist/381.js 10.3 kB +1 B (0%)
packages/esm-appointments-app/dist/437.js 2.47 kB 0 B
packages/esm-appointments-app/dist/460.js 2.17 kB +80 B (+4%)
packages/esm-appointments-app/dist/469.js 6.65 kB 0 B
packages/esm-appointments-app/dist/544.js 748 B 0 B
packages/esm-appointments-app/dist/574.js 1.72 kB +43 B (+3%)
packages/esm-appointments-app/dist/591.js 16.9 kB 0 B
packages/esm-appointments-app/dist/610.js 6.71 kB 0 B
packages/esm-appointments-app/dist/735.js 11.3 kB 0 B
packages/esm-appointments-app/dist/738.js 144 kB 0 B
packages/esm-appointments-app/dist/757.js 1.73 kB +41 B (+2%)
packages/esm-appointments-app/dist/784.js 2.63 kB 0 B
packages/esm-appointments-app/dist/788.js 1.73 kB +41 B (+2%)
packages/esm-appointments-app/dist/80.js 5.1 kB +2 B (0%)
packages/esm-appointments-app/dist/807.js 2.41 kB +52 B (+2%)
packages/esm-appointments-app/dist/833.js 2.04 kB +61 B (+3%)
packages/esm-appointments-app/dist/884.js 1.96 kB 0 B
packages/esm-appointments-app/dist/main.js 5.51 kB 0 B
packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js 3.18 kB 0 B
packages/esm-patient-list-app/dist/130.js 175 kB 0 B
packages/esm-patient-list-app/dist/255.js 4.4 kB 0 B
packages/esm-patient-list-app/dist/292.js 96 kB 0 B
packages/esm-patient-list-app/dist/294.js 3.32 kB 0 B
packages/esm-patient-list-app/dist/319.js 1.08 kB 0 B
packages/esm-patient-list-app/dist/404.js 2.26 kB 0 B
packages/esm-patient-list-app/dist/460.js 1.22 kB 0 B
packages/esm-patient-list-app/dist/477.js 16.3 kB 0 B
packages/esm-patient-list-app/dist/537.js 534 B 0 B
packages/esm-patient-list-app/dist/565.js 2.61 kB 0 B
packages/esm-patient-list-app/dist/574.js 942 B 0 B
packages/esm-patient-list-app/dist/588.js 6.66 kB 0 B
packages/esm-patient-list-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-list-app/dist/716.js 4.62 kB 0 B
packages/esm-patient-list-app/dist/757.js 1.09 kB 0 B
packages/esm-patient-list-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-list-app/dist/788.js 941 B 0 B
packages/esm-patient-list-app/dist/791.js 1.54 kB 0 B
packages/esm-patient-list-app/dist/807.js 1.42 kB 0 B
packages/esm-patient-list-app/dist/833.js 1.13 kB 0 B
packages/esm-patient-list-app/dist/900.js 7.66 kB 0 B
packages/esm-patient-list-app/dist/main.js 3.82 kB 0 B
packages/esm-patient-list-app/dist/openmrs-esm-patient-list-app.js 3.18 kB 0 B
packages/esm-patient-registration-app/dist/117.js 12.1 kB 0 B
packages/esm-patient-registration-app/dist/130.js 175 kB 0 B
packages/esm-patient-registration-app/dist/167.js 27.2 kB 0 B
packages/esm-patient-registration-app/dist/294.js 23.4 kB 0 B
packages/esm-patient-registration-app/dist/319.js 1.59 kB 0 B
packages/esm-patient-registration-app/dist/460.js 1.66 kB 0 B
packages/esm-patient-registration-app/dist/485.js 29 kB 0 B
packages/esm-patient-registration-app/dist/537.js 3.74 kB 0 B
packages/esm-patient-registration-app/dist/558.js 26 kB 0 B
packages/esm-patient-registration-app/dist/574.js 1.36 kB 0 B
packages/esm-patient-registration-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-registration-app/dist/62.js 6.86 kB 0 B
packages/esm-patient-registration-app/dist/635.js 456 B 0 B
packages/esm-patient-registration-app/dist/68.js 9.49 kB 0 B
packages/esm-patient-registration-app/dist/735.js 464 B 0 B
packages/esm-patient-registration-app/dist/742.js 721 B 0 B
packages/esm-patient-registration-app/dist/757.js 1.62 kB 0 B
packages/esm-patient-registration-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-registration-app/dist/788.js 1.29 kB 0 B
packages/esm-patient-registration-app/dist/807.js 2.05 kB 0 B
packages/esm-patient-registration-app/dist/833.js 1.59 kB 0 B
packages/esm-patient-registration-app/dist/857.js 2.08 kB 0 B
packages/esm-patient-registration-app/dist/879.js 2.94 kB 0 B
packages/esm-patient-registration-app/dist/975.js 425 B 0 B
packages/esm-patient-registration-app/dist/main.js 21.6 kB 0 B
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js 3.23 kB 0 B
packages/esm-patient-search-app/dist/110.js 16.9 kB 0 B
packages/esm-patient-search-app/dist/128.js 2.01 kB 0 B
packages/esm-patient-search-app/dist/130.js 175 kB 0 B
packages/esm-patient-search-app/dist/262.js 29.4 kB 0 B
packages/esm-patient-search-app/dist/319.js 934 B 0 B
packages/esm-patient-search-app/dist/327.js 1.05 kB 0 B
packages/esm-patient-search-app/dist/357.js 5.69 kB 0 B
packages/esm-patient-search-app/dist/460.js 1.05 kB +5 B (0%)
packages/esm-patient-search-app/dist/519.js 5.08 kB 0 B
packages/esm-patient-search-app/dist/574.js 779 B 0 B
packages/esm-patient-search-app/dist/588.js 6.66 kB 0 B
packages/esm-patient-search-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-search-app/dist/757.js 935 B 0 B
packages/esm-patient-search-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-search-app/dist/788.js 773 B 0 B
packages/esm-patient-search-app/dist/807.js 1.11 kB 0 B
packages/esm-patient-search-app/dist/833.js 947 B 0 B
packages/esm-patient-search-app/dist/842.js 2.07 kB 0 B
packages/esm-patient-search-app/dist/939.js 4.4 kB 0 B
packages/esm-patient-search-app/dist/982.js 1.69 kB 0 B
packages/esm-patient-search-app/dist/main.js 3.46 kB 0 B
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js 3.19 kB 0 B
packages/esm-service-queues-app/dist/130.js 175 kB 0 B
packages/esm-service-queues-app/dist/176.js 5.76 kB 0 B
packages/esm-service-queues-app/dist/242.js 219 B 0 B
packages/esm-service-queues-app/dist/252.js 2.22 kB 0 B
packages/esm-service-queues-app/dist/286.js 2.88 kB -3 B (0%)
packages/esm-service-queues-app/dist/308.js 8.15 kB +3 B (0%)
packages/esm-service-queues-app/dist/311.js 4.2 kB +2 B (0%)
packages/esm-service-queues-app/dist/319.js 3.15 kB +52 B (+2%)
packages/esm-service-queues-app/dist/328.js 3.08 kB +5 B (0%)
packages/esm-service-queues-app/dist/330.js 8.6 kB +1 B (0%)
packages/esm-service-queues-app/dist/364.js 2.03 kB 0 B
packages/esm-service-queues-app/dist/425.js 3.42 kB 0 B
packages/esm-service-queues-app/dist/433.js 25.7 kB +14 B (0%)
packages/esm-service-queues-app/dist/457.js 2.5 kB 0 B
packages/esm-service-queues-app/dist/460.js 3.97 kB +108 B (+3%)
packages/esm-service-queues-app/dist/469.js 6.66 kB 0 B
packages/esm-service-queues-app/dist/53.js 3.11 kB 0 B
packages/esm-service-queues-app/dist/574.js 3.14 kB +53 B (+2%)
packages/esm-service-queues-app/dist/591.js 16.9 kB 0 B
packages/esm-service-queues-app/dist/610.js 6.71 kB 0 B
packages/esm-service-queues-app/dist/611.js 2.73 kB 0 B
packages/esm-service-queues-app/dist/616.js 3.61 kB 0 B
packages/esm-service-queues-app/dist/627.js 2.94 kB 0 B
packages/esm-service-queues-app/dist/644.js 1.25 kB 0 B
packages/esm-service-queues-app/dist/670.js 155 kB 0 B
packages/esm-service-queues-app/dist/680.js 2.55 kB 0 B
packages/esm-service-queues-app/dist/719.js 5.38 kB -1 B (0%)
packages/esm-service-queues-app/dist/733.js 4.07 kB 0 B
packages/esm-service-queues-app/dist/757.js 3.15 kB +52 B (+2%)
packages/esm-service-queues-app/dist/764.js 5.26 kB +1 B (0%)
packages/esm-service-queues-app/dist/766.js 4.74 kB 0 B
packages/esm-service-queues-app/dist/784.js 2.63 kB 0 B
packages/esm-service-queues-app/dist/788.js 3.13 kB +49 B (+2%)
packages/esm-service-queues-app/dist/807.js 4.39 kB +61 B (+1%)
packages/esm-service-queues-app/dist/833.js 3.74 kB +53 B (+1%)
packages/esm-service-queues-app/dist/86.js 4.4 kB 0 B
packages/esm-service-queues-app/dist/981.js 3.63 kB +2 B (0%)
packages/esm-service-queues-app/dist/main.js 4.01 kB 0 B
packages/esm-service-queues-app/dist/openmrs-esm-service-queues-app.js 3.19 kB 0 B

compressed-size-action

@ibacher
Copy link
Member

ibacher commented Sep 27, 2023 •
edited
Loading

Could you fix the test failure? Otherwise, LGTM.

denniskigen
denniskigen approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @vasharma05.

@ibacher
Copy link
Member

ibacher commented Oct 14, 2023

@vasharma05 Do you have some time to fix the conflicts?

@denniskigen @gracepotma We probably need some conventions around “what makes a good translation key” because errorMessage (removed here) is not too useful. Any thoughts? (It’s a bit hard)

@denniskigen
Copy link
Member

I recall @brandones once said he knew someone who might be interested in reviewing our translation keys and strings. Might that still be the case, Brandon?

@denniskigen denniskigen merged commit bdadcbc into main Oct 19, 2023
6 checks passed
@denniskigen denniskigen deleted the i18n/same-key-different-value-pairs branch October 19, 2023 20:31
@brandones
Copy link
Contributor

I have no recollection :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibacher ibacher ibacher approved these changes

@denniskigen denniskigen denniskigen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vasharma05 @ibacher @denniskigen @brandones