833 cleanup pseudo dual flexi simulations #834

pengguanya · 2024-06-16T11:23:59Z

Pull Request

Fixes #833

github-actions · 2024-06-16T11:39:06Z

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                        87       2  97.70%   72, 432
R/crmPack-package.R                   4       0  100.00%
R/CrmPackClass-methods.R              5       0  100.00%
R/Data-class.R                      156       5  96.79%   43, 565-566, 572-577
R/Data-methods.R                    279       0  100.00%
R/Data-validity.R                   144       1  99.31%   21
R/Design-class.R                    396       0  100.00%
R/Design-methods.R                 2766    1036  62.55%   563-567, 591-594, 602-621, 626-655, 659-660, 662, 677-685, 689, 701-720, 1122-1126, 1253, 1267-1271, 1333, 1523, 1740, 1767-1770, 1779-1790, 1794-1813, 1824-1828, 1834-1846, 2109, 2134-2137, 2144-2155, 2159-2178, 2190-2194, 2200-2212, 2496-2499, 2527-2530, 2538-2550, 2553-2564, 2568-2604, 2621-2630, 2636-2651, 2676, 2717-2718, 2981-3451, 3546-3557, 3560-3571, 3575-3611, 3628-3637, 3645-3660, 3698, 3740-3741, 3989-4545, 4686, 4774
R/Design-validity.R                  34      10  70.59%   47-56
R/fromQuantiles.R                   172      52  69.77%   294-362
R/helpers_broom.R                    74      10  86.49%   30, 34-35, 37-38, 40, 81, 102-104
R/helpers_covr.R                     23       0  100.00%
R/helpers_data.R                     96       1  98.96%   139
R/helpers_design.R                  126      42  66.67%   22, 77-129, 250, 255-259
R/helpers_jags.R                     77       0  100.00%
R/helpers_knitr_CohortSize.R        109       0  100.00%
R/helpers_knitr_Design.R            346       8  97.69%   24-29, 323-324
R/helpers_knitr_GeneralData.R       190      59  68.95%   75-78, 91-94, 107-110, 122-125, 138-141, 163-165, 248-252, 261-306, 354
R/helpers_knitr_GeneralModel.R      730       3  99.59%   105, 401, 813
R/helpers_knitr_Increments.R        165       1  99.39%   305
R/helpers_knitr_NextBest.R          312       0  100.00%
R/helpers_knitr_SafetyWindow.R      142       1  99.30%   103
R/helpers_knitr_Stopping.R          264       0  100.00%
R/helpers_knitr.R                    12       0  100.00%
R/helpers_model.R                    85       4  95.29%   38, 89-90, 139
R/helpers_rules.R                   428       0  100.00%
R/helpers_samples.R                   5       0  100.00%
R/helpers_simulations.R              27       0  100.00%
R/helpers.R                         214      61  71.50%   107-127, 162-178, 200-302, 337-351
R/logger.R                           11       0  100.00%
R/mcmc.R                            290      18  93.79%   92-97, 376-377, 387, 389-390, 393-396, 579-580, 669, 675, 733
R/McmcOptions-class.R                22       0  100.00%
R/McmcOptions-methods.R               8       1  87.50%   43
R/McmcOptions-validity.R             42       0  100.00%
R/Model-class.R                    1062     166  84.37%   145-147, 216-218, 222-224, 283-285, 357-359, 363-365, 444-446, 513-515, 577-581, 584-587, 690-693, 697-698, 813-817, 937-939, 943-951, 1096-1098, 1103-1106, 1110-1113, 1229-1233, 1235-1238, 1242-1245, 1248, 1409-1419, 1424-1430, 1585-1588, 1594-1601, 1758, 1767, 1776, 1785, 1794-1799, 1935, 1944, 1953, 1961-1963, 2807-2836, 2840-2846, 2853-2857, 2862, 2969-2982, 3008, 3104-3106, 3110, 3203-3205, 3209, 3278-3290, 3308, 3368-3370, 3372-3373, 3376-3381
R/Model-methods.R                   505      38  92.48%   78, 233-238, 809-854, 1175-1184
R/Model-validity.R                  443      16  96.39%   430-433, 442-445, 596-604
R/ModelParams-class.R                17       0  100.00%
R/ModelParams-validity.R             21       0  100.00%
R/Rules-class.R                     467       0  100.00%
R/Rules-methods.R                  1590     183  88.49%   889, 892, 895, 1010, 1013, 1016, 1136-1139, 1173, 1276-1279, 1314, 1804, 2668-2676, 2700-2707, 2870-2879, 3195-3204, 3337-3580, 3867, 3871
R/Rules-validity.R                  454      36  92.07%   335-340, 694-733
R/Samples-class.R                     6       0  100.00%
R/Samples-methods.R                1188      21  98.23%   410-420, 648, 1665-1666, 1698, 1711, 1893, 2223-2228
R/Samples-validity.R                 10       0  100.00%
R/Simulations-class.R               208      99  52.40%   171-182, 419-493, 937-970, 998
R/Simulations-methods.R            1617    1473  8.91%    65-350, 406, 416-435, 448-453, 500-509, 674-2969
R/Simulations-validity.R             75      75  0.00%    20-168
R/utils.R                             6       0  100.00%
TOTAL                             15510    3422  77.94%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  -------
R/Simulations-class.R        0      -4  +1.92%
TOTAL                        0      -4  +0.03%

Results for commit: 8696724

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

…oche/crmPack into 833-cleanup-PseudoDualFlexiSimulations

github-actions · 2024-06-17T19:16:53Z

Unit Tests Summary

1 files 45 suites 2m 19s ⏱️
1 354 tests 1 197 ✅ 157 💤 0 ❌
6 586 runs 6 391 ✅ 195 💤 0 ❌

Results for commit 8696724.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-17T19:16:59Z

Unit Test Performance Difference

Additional test case details

Test Suite	$Status$	$±Time$	Test Case
Simulations-class	👶	$+0.01$	PseudoDualFlexiSimulations_can_be_generated_without_error_and_return_a_valid_object
Simulations-class	👶	$+0.03$	PseudoDualFlexiSimulations_can_be_instantiated_using_the_constructor
Simulations-class	👶	$+0.00$	PseudoDualFlexiSimulations_user_constructor_argument_names

Results for commit 129ce54

♻️ This comment has been updated with latest results.

…oche/crmPack into 833-cleanup-PseudoDualFlexiSimulations

danielinteractive

nice work, thanks Guanya, one suggestion below

R/Design-methods.R

Co-authored-by: Daniel Sabanes Bove <[email protected]>

danielinteractive

Thanks @pengguanya !

…oche/crmPack into 833-cleanup-PseudoDualFlexiSimulations

…lFlexiSimulations

danielinteractive · 2024-08-12T02:54:50Z

I guess the pkgdown fails because of still missing alt text, so need to wait for @Puzzled-Face PR?

pengguanya added 6 commits June 16, 2024 12:13

clean

11b29b8

add test

b5984e8

move nolint st

edd3e3b

test

2d74e31

doc

e36d756

fix var

e08e70c

pengguanya requested a review from danielinteractive as a code owner June 16, 2024 11:24

[skip style] [skip vbump] Restyle files

5429fe9

pengguanya and others added 4 commits June 17, 2024 20:38

fix var name

bb7a26d

fix lint error

0510664

Merge branch '833-cleanup-PseudoDualFlexiSimulations' of github.com:R…

892132c

…oche/crmPack into 833-cleanup-PseudoDualFlexiSimulations

[skip style] [skip vbump] Restyle files

7e87e07

pengguanya added 3 commits June 18, 2024 11:03

trigger checks

b1f0dff

Merge branch '833-cleanup-PseudoDualFlexiSimulations' of github.com:R…

fe6b6ac

…oche/crmPack into 833-cleanup-PseudoDualFlexiSimulations

trigger checks

a50f3d3

danielinteractive reviewed Jun 20, 2024

View reviewed changes

danielinteractive reviewed Jun 25, 2024

View reviewed changes

R/Design-methods.R Outdated Show resolved Hide resolved

Update R/Design-methods.R

cc76990

Co-authored-by: Daniel Sabanes Bove <[email protected]>

danielinteractive self-requested a review August 3, 2024 13:03

danielinteractive approved these changes Aug 3, 2024

View reviewed changes

pengguanya added 7 commits August 5, 2024 23:10

trigger checks

7c4fa02

Merge branch '833-cleanup-PseudoDualFlexiSimulations' of github.com:R…

f8610ca

…oche/crmPack into 833-cleanup-PseudoDualFlexiSimulations

trigger checks

2c80578

Merge remote-tracking branch 'origin/main' into 833-cleanup-PseudoDua…

b062489

…lFlexiSimulations

trigger checks

3a2fb73

trigger checks

688f7fe

trigger checks

bbfa633

pengguanya added 2 commits August 10, 2024 08:33

trigger checks

8969205

fix par names

92421f2

Merge branch 'main' into 833-cleanup-PseudoDualFlexiSimulations

8696724

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

833 cleanup pseudo dual flexi simulations #834

833 cleanup pseudo dual flexi simulations #834

pengguanya commented Jun 16, 2024

github-actions bot commented Jun 16, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

danielinteractive left a comment

danielinteractive left a comment

danielinteractive commented Aug 12, 2024

833 cleanup pseudo dual flexi simulations #834

Are you sure you want to change the base?

833 cleanup pseudo dual flexi simulations #834

Conversation

pengguanya commented Jun 16, 2024

Pull Request

github-actions bot commented Jun 16, 2024 • edited Loading

Code Coverage Summary

Diff against main

github-actions bot commented Jun 17, 2024 • edited Loading

Unit Tests Summary

github-actions bot commented Jun 17, 2024 • edited Loading

Unit Test Performance Difference

danielinteractive left a comment

Choose a reason for hiding this comment

danielinteractive left a comment

Choose a reason for hiding this comment

danielinteractive commented Aug 12, 2024

github-actions bot commented Jun 16, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading