Initial outline for allowing processing of in-memory buffers #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bitsgalore
This is an outline of a modification we would find useful for the BL Blitter work (see britishlibrary/blitter#4).
We'd like to be able to operate on in-memory data, but the current
checkOneFile
API is hard-coded to work on files. I've tried two different ways of implementing this, and this pull request seems to be the cleanest. But note I've not actually tested it yet!Before testing it properly, I wanted to find out if you were happy to support in-memory analysis and if so, what you thought would be the cleanest way of implementing it?
(The other tactic I tried -- and used in production -- is here: https://github.com/britishlibrary/blitter/blob/master/jpylyzer/jpylyzer.py#L290-L318 . The problem with that approach is it makes handling errors more difficult).