Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial outline for allowing processing of in-memory buffers #106

Closed

Conversation

anjackson
Copy link
Member

@anjackson anjackson commented Aug 30, 2017

Hi @bitsgalore

This is an outline of a modification we would find useful for the BL Blitter work (see britishlibrary/blitter#4).

We'd like to be able to operate on in-memory data, but the current checkOneFile API is hard-coded to work on files. I've tried two different ways of implementing this, and this pull request seems to be the cleanest. But note I've not actually tested it yet!

Before testing it properly, I wanted to find out if you were happy to support in-memory analysis and if so, what you thought would be the cleanest way of implementing it?

(The other tactic I tried -- and used in production -- is here: https://github.com/britishlibrary/blitter/blob/master/jpylyzer/jpylyzer.py#L290-L318 . The problem with that approach is it makes handling errors more difficult).

@bitsgalore
Copy link
Member

Hi @anjackson,

This looks like a useful improvement. Just let me know when you've completed testing, would be happy to accept a pull request along these lines.

@bitsgalore
Copy link
Member

Closing because #162 takes care of this.

@bitsgalore bitsgalore closed this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants