DeclarationSiteTypeVariance doesn't change bounds when they refer to …

…final classes / issue #2621
openrewrite · Jan 11, 2023 · c414e02 · c414e02
1 parent 4ea75c7
commit c414e02
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 3 deletions.
diff --git a/...java-test/src/test/java/org/openrewrite/java/cleanup/DeclarationSiteTypeVarianceTest.java b/...java-test/src/test/java/org/openrewrite/java/cleanup/DeclarationSiteTypeVarianceTest.java
@@ -116,4 +116,32 @@ void test(Function<String, Integer> f) {
           )
         );
     }
+
+    @Test
+    void finalClasses() {
+        rewriteRun(
+          java(
+            """
+              final class In {}
+              interface Out {}
+              """
+          ),
+          java(
+            """
+              import java.util.function.Function;
+              class Test {
+                  void test(Function<In, Out> f) {
+                  }
+              }
+              """,
+            """
+              import java.util.function.Function;
+              class Test {
+                  void test(Function<In, ? extends Out> f) {
+                  }
+              }
+              """
+          )
+        );
+    }
 }
diff --git a/rewrite-java/src/main/java/org/openrewrite/java/cleanup/DeclarationSiteTypeVariance.java b/rewrite-java/src/main/java/org/openrewrite/java/cleanup/DeclarationSiteTypeVariance.java
@@ -104,9 +104,15 @@ private J.ParameterizedType useDeclarationSiteVariance(J.ParameterizedType pt, V
                         variance == VariantTypeSpec.Variance.INVARIANT) {
                         return tp;
                     }
-                    for (String excludedBound : excludedBounds) {
-                        JavaType.FullyQualified fq = TypeUtils.asFullyQualified(tp.getType());
-                        if (fq != null && StringUtils.matchesGlob(fq.getFullyQualifiedName(), excludedBound)) {
+
+                    JavaType.FullyQualified fq = TypeUtils.asFullyQualified(tp.getType());
+                    if (fq != null) {
+                        for (String excludedBound : excludedBounds) {
+                            if (StringUtils.matchesGlob(fq.getFullyQualifiedName(), excludedBound)) {
+                                return tp;
+                            }
+                        }
+                        if (fq.getFlags().contains(Flag.Final)) {
                             return tp;
                         }
                     }