Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run S3 source integration tests as GHA #3847

Open
dlvenable opened this issue Dec 12, 2023 · 0 comments
Open

Run S3 source integration tests as GHA #3847

dlvenable opened this issue Dec 12, 2023 · 0 comments
Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc.

Comments

@dlvenable
Copy link
Member

Is your feature request related to a problem? Please describe.

The s3 source integration tests do not run automatically. Thus, PRs may be breaking behavior without our knowing.

Describe the solution you'd like

Run the s3 source integration tests as part of the GitHub Action. To support this, create an S3 bucket and SQS queue in the testing CDK.

It may also be advantageous to update the tests to write to a key prefix depending on the use-case: SQS notifications versus S3 scan. Then the SQS queue can trigger for events only a known key prefix. This way we don't need a bucket per use-case.

@dlvenable dlvenable added this to the v2.7 milestone Dec 12, 2023
@dlvenable dlvenable added the maintenance Issues to help maintain the project, such as improving builds, testing, etc. label Dec 12, 2023
@dlvenable dlvenable moved this from Unplanned to To do in Data Prepper Tracking Board Dec 13, 2023
@dlvenable dlvenable modified the milestones: v2.7, v2.8 Jan 30, 2024
@dlvenable dlvenable modified the milestones: v2.8, v2.9 Apr 17, 2024
@dlvenable dlvenable removed this from the v2.9 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc.
Projects
Development

No branches or pull requests

2 participants