Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ddb metrics changes #3498

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Ddb metrics changes #3498

merged 1 commit into from
Oct 16, 2023

Conversation

graytaylor0
Copy link
Member

@graytaylor0 graytaylor0 commented Oct 12, 2023 •
edited
Loading

Description

  • Renames some metrics for the ddb source
  • Add metrics for activeExportS3ObjectConsumers and activeChangeEventConsumers to give indication of how many nodes are processing shards or export files at a time.
  • Rename _id metadata key to primary_key
  • Attempts to fix flaky tests for [BUG] Flaky test in DataFileLoaderTest #3470, but did not work so disabled them for now

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@graytaylor0 graytaylor0 marked this pull request as ready for review October 13, 2023 17:09
@graytaylor0 graytaylor0 force-pushed the DdbMetricsChanges branch 4 times, most recently from 7df72d0 to 39d0903 Compare October 16, 2023 16:40
@graytaylor0 graytaylor0 merged commit 910f451 into opensearch-project:main Oct 16, 2023
24 checks passed
@graytaylor0 graytaylor0 deleted the DdbMetricsChanges branch October 16, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinujoh dinujoh dinujoh approved these changes

@engechas engechas engechas approved these changes

@chenqi0805 chenqi0805 Awaiting requested review from chenqi0805 chenqi0805 is a code owner

@kkondaka kkondaka Awaiting requested review from kkondaka kkondaka is a code owner

@asifsmohammed asifsmohammed Awaiting requested review from asifsmohammed

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@oeyh oeyh Awaiting requested review from oeyh oeyh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graytaylor0 @engechas @dinujoh